From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 598ECC433DF for ; Mon, 3 Aug 2020 16:59:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 338FF20A8B for ; Mon, 3 Aug 2020 16:59:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="xi+Hs7ZK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728034AbgHCQ7D (ORCPT ); Mon, 3 Aug 2020 12:59:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726664AbgHCQ7D (ORCPT ); Mon, 3 Aug 2020 12:59:03 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3666C06174A for ; Mon, 3 Aug 2020 09:59:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=UlriNvX6+STsFx+IilFd2tRB1Lnp92AIhazSyvvSgzo=; b=xi+Hs7ZKWTYmM1naxSd+uN1M8 Vfqd1bXUC9AN5rlWHLWYMuOwwX17fBn51cvwFJrChmc3GbZU7dWS8MI5uyk0NB9cPHOFr6l5CX7PK rKb25lCMBlbZUDzFpEfmnH9vR79MMYhycMbiVcOSkAhqwGFPVbJcovWhf8yRgT4TPjtE49W40h+XD RhXzRcXU+TXnpqTgte0fI81IVKO7+hyCDzJiCvjokdlR+cXLVrJXlu9qeTJ3wbe/LI2o099CyTdJn zLad0CeItwpUI0cbFdbimh+yTstdeY5Lj5uiQvckauGYftmNPnDTtynXdoZ8NEorussG3Uvq64giW 97NprGr1w==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:47868) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2dng-0001jY-PN; Mon, 03 Aug 2020 17:59:00 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1k2dng-0003FA-7S; Mon, 03 Aug 2020 17:59:00 +0100 Date: Mon, 3 Aug 2020 17:59:00 +0100 From: Russell King - ARM Linux admin To: Andrew Lunn Cc: "Madalin Bucur (OSS)" , Vikas Singh , "f.fainelli@gmail.com" , "hkallweit1@gmail.com" , "netdev@vger.kernel.org" , "Calvin Johnson (OSS)" , kuldip dwivedi , Vikas Singh Subject: Re: [PATCH 2/2] net: phy: Associate device node with fixed PHY Message-ID: <20200803165900.GQ1551@shell.armlinux.org.uk> References: <20200731153119.GJ1712415@lunn.ch> <20200801094132.GH1551@shell.armlinux.org.uk> <20200801151107.GK1712415@lunn.ch> <20200803090716.GL1551@shell.armlinux.org.uk> <20200803125742.GK1862409@lunn.ch> <20200803150051.GA1919070@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200803150051.GA1919070@lunn.ch> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Aug 03, 2020 at 05:00:51PM +0200, Andrew Lunn wrote: > On Mon, Aug 03, 2020 at 02:33:56PM +0000, Madalin Bucur (OSS) wrote: > > > -----Original Message----- > > > From: Andrew Lunn > > > Sent: 03 August 2020 15:58 > > > To: Madalin Bucur (OSS) > > > Cc: Russell King - ARM Linux admin ; Vikas Singh > > > ; f.fainelli@gmail.com; hkallweit1@gmail.com; > > > netdev@vger.kernel.org; Calvin Johnson (OSS) ; > > > kuldip dwivedi ; Vikas Singh > > > > > > Subject: Re: [PATCH 2/2] net: phy: Associate device node with fixed PHY > > > > > > > I see you agree that there were and there will be many changes for a > > > while, > > > > It's not a complaint, I know hot it works, it's just a decision based on > > > > required effort vs features offered vs user requirements. Lately it's > > > been > > > > time consuming to try to fix things in this area. > > > > > > So the conclusion to all this that you are unwilling to use the > > > correct API for this, which would be phylink, and the SFP code. So: > > > > > > NACK > > > > > > Andrew > > > > You've rejected a generic change - ACPI support for fixed link. > > The discussion above is just an example of how it could have been (mis-)used. > > Are you rejecting the general case or just the particular one? > > So far, nobody has corrected me that the MAC is not connected to an > SFP socket. So i see two sorts of abuse going on here: > > 1) Using a fixed link with a hack to allow 10G. phylink allows 10G > fixed links without an hacks. > > 2) Using a fixed link when not even appropriate since phylink should > be used to control the SFP. > > Now, you can do whatever you want in your Vendor Crap tree. But there > is no reason mainline should help you support your vendor crap tree. +1 for everything above. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!