From: kernel test robot <lkp@intel.com>
To: yzc666@netease.com, bjorn@mork.no
Cc: kbuild-all@lists.01.org, davem@davemloft.net, kuba@kernel.org,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
carl <carl.yin@quectel.com>
Subject: Re: [PATCH] qmi_wwan: support modify usbnet's rx_urb_size
Date: Mon, 3 Aug 2020 18:01:46 +0800 [thread overview]
Message-ID: <202008031745.i7nguP22%lkp@intel.com> (raw)
In-Reply-To: <20200803065105.8997-1-yzc666@netease.com>
[-- Attachment #1: Type: text/plain, Size: 2177 bytes --]
Hi,
I love your patch! Yet something to improve:
[auto build test ERROR on sparc-next/master]
[also build test ERROR on linus/master v5.8 next-20200731]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/yzc666-netease-com/qmi_wwan-support-modify-usbnet-s-rx_urb_size/20200803-152459
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc-next.git master
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/net/usb/qmi_wwan.c:546:3: error: 'dev_attr_rx_urb_size' undeclared here (not in a function)
546 | &dev_attr_rx_urb_size.attr,
| ^~~~~~~~~~~~~~~~~~~~
drivers/net/usb/qmi_wwan.c:410:16: warning: 'rx_urb_size_store' defined but not used [-Wunused-function]
410 | static ssize_t rx_urb_size_store(struct device *d, struct device_attribute *attr,
| ^~~~~~~~~~~~~~~~~
drivers/net/usb/qmi_wwan.c:403:16: warning: 'rx_urb_size_show' defined but not used [-Wunused-function]
403 | static ssize_t rx_urb_size_show(struct device *d, struct device_attribute *attr, char *buf)
| ^~~~~~~~~~~~~~~~
vim +/dev_attr_rx_urb_size +546 drivers/net/usb/qmi_wwan.c
544
545 static struct attribute *qmi_wwan_sysfs_attrs[] = {
> 546 &dev_attr_rx_urb_size.attr,
547 &dev_attr_raw_ip.attr,
548 &dev_attr_add_mux.attr,
549 &dev_attr_del_mux.attr,
550 NULL,
551 };
552
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 55659 bytes --]
prev parent reply other threads:[~2020-08-03 10:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 6:51 [PATCH] qmi_wwan: support modify usbnet's rx_urb_size yzc666
2020-08-03 8:16 ` Greg KH
2020-08-03 8:26 ` Daniele Palmas
2020-08-03 9:49 ` Greg KH
2020-08-03 10:33 ` Daniele Palmas
2020-08-03 10:40 ` Bjørn Mork
2020-08-03 10:35 ` 答复: " Carl Yin(殷张成)
2020-08-03 10:32 ` Bjørn Mork
2020-08-03 12:08 ` 答复: " Carl Yin(殷张成)
2020-08-03 14:05 ` Bjørn Mork
2020-08-03 8:38 ` Sergei Shtylyov
2020-08-03 10:01 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202008031745.i7nguP22%lkp@intel.com \
--to=lkp@intel.com \
--cc=bjorn@mork.no \
--cc=carl.yin@quectel.com \
--cc=davem@davemloft.net \
--cc=kbuild-all@lists.01.org \
--cc=kuba@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yzc666@netease.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).