From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CA5BC433E1 for ; Mon, 3 Aug 2020 23:59:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 53D8620786 for ; Mon, 3 Aug 2020 23:59:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729563AbgHCX73 (ORCPT ); Mon, 3 Aug 2020 19:59:29 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:41496 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729146AbgHCX72 (ORCPT ); Mon, 3 Aug 2020 19:59:28 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1k2kMZ-0088ms-2e; Tue, 04 Aug 2020 01:59:27 +0200 Date: Tue, 4 Aug 2020 01:59:27 +0200 From: Andrew Lunn To: Michal Kubecek Cc: netdev@vger.kernel.org Subject: Re: [PATCH ethtool 2/7] cable_test: clean up unused parameters Message-ID: <20200803235927.GO1862409@lunn.ch> References: <4e6a60bf95b819912eb08cb13276791d8ec9feac.1596451857.git.mkubecek@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4e6a60bf95b819912eb08cb13276791d8ec9feac.1596451857.git.mkubecek@suse.cz> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Aug 03, 2020 at 01:57:09PM +0200, Michal Kubecek wrote: > Functions nl_cable_test_ntf_attr() and nl_cable_test_tdr_ntf_attr() do not > use nlctx parameter and as they are not callbacks with fixed signature, we > can simply drop it. Once we do, the same is true for cable_test_ntf_nest() > and cable_test_tdr_ntf_nest(). > > Signed-off-by: Michal Kubecek Reviewed-by: Andrew Lunn Andrew