* [PATCH v4] net: ethernet: mtk_eth_soc: fix MTU warnings
[not found] <20200804165555.75159-1-linux@fw-web.de>
@ 2020-08-04 16:55 ` Frank Wunderlich
2020-08-04 17:20 ` Aw: " Frank Wunderlich
0 siblings, 1 reply; 4+ messages in thread
From: Frank Wunderlich @ 2020-08-04 16:55 UTC (permalink / raw)
To: linux-mediatek
Cc: Frank Wunderlich, Chun-Kuang Hu, Philipp Zabel, David Airlie,
Daniel Vetter, Matthias Brugger, dri-devel, linux-arm-kernel,
linux-kernel, Landen Chao, Felix Fietkau, John Crispin, Sean Wang,
Mark Lee, David S. Miller, Jakub Kicinski, netdev, Andrew Lunn
From: Landen Chao <landen.chao@mediatek.com>
in recent kernel versions there are warnings about incorrect MTU size
like these:
eth0: mtu greater than device maximum
mtk_soc_eth 1b100000.ethernet eth0: error -22 setting MTU to include DSA overhead
Fixes: bfcb813203e6 ("net: dsa: configure the MTU for switch ports")
Fixes: 72579e14a1d3 ("net: dsa: don't fail to probe if we couldn't set the MTU")
Fixes: 7a4c53bee332 ("net: report invalid mtu value via netlink extack")
Signed-off-by: Landen Chao <landen.chao@mediatek.com>
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
---
v3->v4
- fix commit-message (hyphernations,capitalisation) as suggested by Russell
- add Signed-off-by Landen
- dropped wrong signed-off from rene (because previous v1/2 was from him)
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index 85735d32ecb0..a1c45b39a230 100644
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -2891,6 +2891,8 @@ static int mtk_add_mac(struct mtk_eth *eth, struct device_node *np)
eth->netdev[id]->irq = eth->irq[0];
eth->netdev[id]->dev.of_node = np;
+ eth->netdev[id]->max_mtu = MTK_MAX_RX_LENGTH - MTK_RX_ETH_HLEN;
+
return 0;
free_netdev:
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Aw: [PATCH v4] net: ethernet: mtk_eth_soc: fix MTU warnings
2020-08-04 16:55 ` [PATCH v4] net: ethernet: mtk_eth_soc: fix MTU warnings Frank Wunderlich
@ 2020-08-04 17:20 ` Frank Wunderlich
0 siblings, 0 replies; 4+ messages in thread
From: Frank Wunderlich @ 2020-08-04 17:20 UTC (permalink / raw)
To: Frank Wunderlich
Cc: linux-mediatek, Chun-Kuang Hu, Philipp Zabel, David Airlie,
Daniel Vetter, Matthias Brugger, dri-devel, linux-arm-kernel,
linux-kernel, Landen Chao, Felix Fietkau, John Crispin, Sean Wang,
Mark Lee, David S. Miller, Jakub Kicinski, netdev, Andrew Lunn
sorry, send this accidentally while posting my hdmi series v4 (have not deleted patch-file)
just ignore this...it's already merged
regards Frank
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v4] net: ethernet: mtk_eth_soc: fix MTU warnings
@ 2020-07-29 8:15 Frank Wunderlich
2020-07-30 23:56 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Frank Wunderlich @ 2020-07-29 8:15 UTC (permalink / raw)
To: linux-mediatek
Cc: Landen Chao, Felix Fietkau, John Crispin, Sean Wang, Mark Lee,
David S. Miller, Jakub Kicinski, Matthias Brugger, netdev,
linux-arm-kernel, linux-kernel, Frank Wunderlich, Andrew Lunn
From: Landen Chao <landen.chao@mediatek.com>
in recent kernel versions there are warnings about incorrect MTU size
like these:
eth0: mtu greater than device maximum
mtk_soc_eth 1b100000.ethernet eth0: error -22 setting MTU to include DSA overhead
Fixes: bfcb813203e6 ("net: dsa: configure the MTU for switch ports")
Fixes: 72579e14a1d3 ("net: dsa: don't fail to probe if we couldn't set the MTU")
Fixes: 7a4c53bee332 ("net: report invalid mtu value via netlink extack")
Signed-off-by: Landen Chao <landen.chao@mediatek.com>
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
---
v3->v4
- fix commit-message (hyphernations,capitalisation) as suggested by Russell
- add Signed-off-by Landen
- dropped wrong signed-off from rene (because previous v1/2 was from him)
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index 85735d32ecb0..a1c45b39a230 100644
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -2891,6 +2891,8 @@ static int mtk_add_mac(struct mtk_eth *eth, struct device_node *np)
eth->netdev[id]->irq = eth->irq[0];
eth->netdev[id]->dev.of_node = np;
+ eth->netdev[id]->max_mtu = MTK_MAX_RX_LENGTH - MTK_RX_ETH_HLEN;
+
return 0;
free_netdev:
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v4] net: ethernet: mtk_eth_soc: fix MTU warnings
2020-07-29 8:15 Frank Wunderlich
@ 2020-07-30 23:56 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2020-07-30 23:56 UTC (permalink / raw)
To: frank-w
Cc: linux-mediatek, landen.chao, nbd, john, sean.wang, Mark-MC.Lee,
kuba, matthias.bgg, netdev, linux-arm-kernel, linux-kernel,
andrew
From: Frank Wunderlich <frank-w@public-files.de>
Date: Wed, 29 Jul 2020 10:15:17 +0200
> From: Landen Chao <landen.chao@mediatek.com>
>
> in recent kernel versions there are warnings about incorrect MTU size
> like these:
>
> eth0: mtu greater than device maximum
> mtk_soc_eth 1b100000.ethernet eth0: error -22 setting MTU to include DSA overhead
>
> Fixes: bfcb813203e6 ("net: dsa: configure the MTU for switch ports")
> Fixes: 72579e14a1d3 ("net: dsa: don't fail to probe if we couldn't set the MTU")
> Fixes: 7a4c53bee332 ("net: report invalid mtu value via netlink extack")
> Signed-off-by: Landen Chao <landen.chao@mediatek.com>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> ---
> v3->v4
> - fix commit-message (hyphernations,capitalisation) as suggested by Russell
> - add Signed-off-by Landen
> - dropped wrong signed-off from rene (because previous v1/2 was from him)
Applied, thank you.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-08-04 17:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20200804165555.75159-1-linux@fw-web.de>
2020-08-04 16:55 ` [PATCH v4] net: ethernet: mtk_eth_soc: fix MTU warnings Frank Wunderlich
2020-08-04 17:20 ` Aw: " Frank Wunderlich
2020-07-29 8:15 Frank Wunderlich
2020-07-30 23:56 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).