From: Vladimir Oltean <olteanv@gmail.com>
To: Eric Dumazet <edumazet@google.com>
Cc: "Gaube, Marvin (THSE-TL1)" <Marvin.Gaube@tesat.de>,
Florian Fainelli <f.fainelli@gmail.com>,
Woojung Huh <woojung.huh@microchip.com>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: PROBLEM: (DSA/Microchip): 802.1Q-Header lost on KSZ9477-DSA ingress without bridge
Date: Tue, 4 Aug 2020 22:29:33 +0300 [thread overview]
Message-ID: <20200804192933.pe32dhfkrlspdhot@skbuf> (raw)
In-Reply-To: <CANn89iKD1H9idd-TpHQ-KS7vYHnz+6VhymrgD2cuGAUHgp2Zpg@mail.gmail.com>
On Tue, Aug 04, 2020 at 07:54:18AM -0700, Eric Dumazet wrote:
>
> My 2013 commit was a bug fix, and hinted that in the future (eg in
> net-next tree) the stop-the-bleed could be refined.
>
> + /* Note: we might in the future use prio bits
> + * and set skb->priority like in vlan_do_receive()
> + * For the time being, just ignore Priority Code Point
> + */
> + skb->vlan_tci = 0;
>
> If you believe this can be done, this is great.
Do you have a reproducer for that bug? I am willing to spend some time
understand what is going on. This has nothing to do with priority. You
vaguely described a problem with 802.1p (VLAN 0) and used that as an
excuse to clear the entire vlan hwaccel tag regardless of VLAN ID. I'm
curious because we also now have commit 36b2f61a42c2 ("net: handle
802.1P vlan 0 packets properly") in that general area, and I simply want
to know if your patch still serves a valid purpose or not.
Thanks,
-Vladimir
next prev parent reply other threads:[~2020-08-04 19:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 6:05 PROBLEM: (DSA/Microchip): 802.1Q-Header lost on KSZ9477-DSA ingress without bridge Gaube, Marvin (THSE-TL1)
2020-07-29 13:48 ` Florian Fainelli
2020-07-29 14:49 ` AW: " Gaube, Marvin (THSE-TL1)
2020-07-29 15:02 ` Florian Fainelli
2020-07-30 9:34 ` AW: " Gaube, Marvin (THSE-TL1)
2020-08-04 14:14 ` Gaube, Marvin (THSE-TL1)
2020-08-04 14:27 ` Vladimir Oltean
2020-08-04 14:54 ` Eric Dumazet
2020-08-04 19:29 ` Vladimir Oltean [this message]
2020-08-04 19:40 ` Eric Dumazet
2020-08-04 19:43 ` Vladimir Oltean
2020-08-04 20:36 ` Eric Dumazet
2020-08-04 21:24 ` Vladimir Oltean
2020-08-04 22:29 ` Eric Dumazet
2020-08-04 22:39 ` Vladimir Oltean
2020-08-04 22:44 ` Vladimir Oltean
2020-08-04 23:02 ` Steinar H. Gunderson
2020-08-04 15:51 ` AW: AW: " Florian Fainelli
2020-08-04 19:54 ` Vladimir Oltean
2020-08-04 20:20 ` Florian Fainelli
2020-08-05 5:45 ` AW: " Gaube, Marvin (THSE-TL1)
2020-09-15 0:02 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200804192933.pe32dhfkrlspdhot@skbuf \
--to=olteanv@gmail.com \
--cc=Marvin.Gaube@tesat.de \
--cc=UNGLinuxDriver@microchip.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox