From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E01BC433E0 for ; Tue, 4 Aug 2020 19:54:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4837F20842 for ; Tue, 4 Aug 2020 19:54:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sQzud/Xr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727887AbgHDTy2 (ORCPT ); Tue, 4 Aug 2020 15:54:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726090AbgHDTy2 (ORCPT ); Tue, 4 Aug 2020 15:54:28 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1222C06174A for ; Tue, 4 Aug 2020 12:54:27 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id d6so29954237ejr.5 for ; Tue, 04 Aug 2020 12:54:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=h0o37mqlvJHF7/2fY9yuDetnb6ERD/AxS8JKStsNeh0=; b=sQzud/XrtfyYlcoTRp3IJpETo3vQDolNmZiPxBrVIsumSAvZwGwqk+8w+BBM5yAWrV sL49K+EtFrT/DKNgNgzBBebm44MC9BVQGXugQwcd+f8l6wQSiY9sD+l1TkzMS6JwovDc aGlUpWni3CABLpVvXo+XfUlE1ZKYYJzb9xdaSMCu3/v/yoS7WhC26fYTS03O5HFymk+C WLIsAxUUg7hUJ1iAfK27AO2HxbkN8rjEnkW0lZCDppJK4oTJK4RuBQhSlXKinPPPeyRo l4BbCiItfeW6Z+PBIxZ4NjkoJK8OCXECQilsoYi86tlLt/bJ4IHQ/qX/54UKiarCHWMk IH0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=h0o37mqlvJHF7/2fY9yuDetnb6ERD/AxS8JKStsNeh0=; b=MQuGmkyvP+yPi9ng8zAge2sw+Mm9LW+i7uQXvju+NRlM+uGqAShBeNpxS/LUFOs7hx XAs2b5TPM9bxdi3385dYEiHet75Ayt4bqL372pJC+KZRDB1QjMENPp5rrALncfsOhTSi ARlxbBDIbAP0snPx1K9RoXAtnNZwFfxB4lvvR4+EhIUpRRKkAysg5BCLb2JYEesicIMM vrekqi4O3hasty6QuLxprbAnlhuiOuYIUiYSGFc5M9Q5X8J05xWm1S40NkV5h/pVJQ1Q miN7GDgTDCrrwr3HBFju66CohSM7xuXVVVFXY5qoSaM74SSENR7OeHlryzxrigXJRxzM LAcw== X-Gm-Message-State: AOAM531qDtpSEUyYqqrbPwITmvgScyOPnFDLFz9tq5iAAs7cAJ1PLhuq 9d/PqameoOZr1nlfdlkC8ek= X-Google-Smtp-Source: ABdhPJw0VHI3+w0v0z2w9EM6Qi5mMhmKAKGdPJgMlBWM+5PQJYhHeJ92nLsKE1ts7nryiQSouqt5GA== X-Received: by 2002:a17:906:4c97:: with SMTP id q23mr10224086eju.11.1596570865315; Tue, 04 Aug 2020 12:54:25 -0700 (PDT) Received: from skbuf ([188.26.57.97]) by smtp.gmail.com with ESMTPSA id q21sm19028396ejr.75.2020.08.04.12.54.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2020 12:54:24 -0700 (PDT) Date: Tue, 4 Aug 2020 22:54:23 +0300 From: Vladimir Oltean To: Florian Fainelli Cc: "Gaube, Marvin (THSE-TL1)" , Woojung Huh , Microchip Linux Driver Support , "netdev@vger.kernel.org" Subject: Re: PROBLEM: (DSA/Microchip): 802.1Q-Header lost on KSZ9477-DSA ingress without bridge Message-ID: <20200804195423.ixeevhsviap535on@skbuf> References: <020a80686edc48d5810e1dbf884ae497@BK99MAIL02.bk.local> <800bbbe8-2c51-114c-691b-137fd96a6ccd@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <800bbbe8-2c51-114c-691b-137fd96a6ccd@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Aug 04, 2020 at 08:51:00AM -0700, Florian Fainelli wrote: > "I looked into it deeper, the driver does rxvlan offloading." > > Is this part of the driver upstream or are you using a vendor tree from > Freescale which has that change included? > Does it matter? FWIW, mainline fec does declare NETIF_F_HW_VLAN_CTAG_RX: https://elixir.bootlin.com/linux/latest/source/drivers/net/ethernet/freescale/fec_main.c#L3317 and move it to the hwaccel area on RX: https://elixir.bootlin.com/linux/latest/source/drivers/net/ethernet/freescale/fec_main.c#L1513