From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D672C433DF for ; Wed, 5 Aug 2020 00:12:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3274F20738 for ; Wed, 5 Aug 2020 00:12:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Awk+RGme" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728250AbgHEAMG (ORCPT ); Tue, 4 Aug 2020 20:12:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727920AbgHEAMF (ORCPT ); Tue, 4 Aug 2020 20:12:05 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84B0CC06174A for ; Tue, 4 Aug 2020 17:12:05 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id di22so24006899edb.12 for ; Tue, 04 Aug 2020 17:12:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=To2yhbXWe/noZ+COhMz78hScmYZu/wsBpod+qzeIci4=; b=Awk+RGmeP9g6mCrYN0f7qchQcNsb5hm7sBpV0Rv4dnlIATuDL5/Ql1unrKIuB2Ptq/ dq0Z6TxJvxhCF6iA5vDSeDF9nu2+NrzW61+ihlYPFe68bOIe2uX8delcx0hcwNPGmI/N 9VgfuKDLX0b0+W3Ds2XU4LNC/ILtUWJmMQzzRR+/I+LfYFGGtugyecG4/kB0alOHMPCh goez1SVU5q2BEft90SpCiTmeCQ6g4YMm3PHY1KBo7MhTqrWPPvDtyDrcCkFz/ayxEWAm GSRN77Ly5V7OBAnJJgGJzHlz6JJ0Ukr+Kuk6y3d6jQnb9EP3Q1sgCoW4by/mU0+LEAK1 UXpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=To2yhbXWe/noZ+COhMz78hScmYZu/wsBpod+qzeIci4=; b=iHiOlaR/18KjjUXrzx4N8pGzXOPka8cxumiQn1PcOGHv7xFpq+Aq/Lxqn4PpcbQAer lTR4UzTMg2gLbQWFjEAoVDnKmFwJKoXoqCzcBgZ11ZZlVeB22BUZMoqAussnedeseSpg iLUtphn50YUK1RmCoWvFKgwNypFtdySQgVTcnx7eoHdN1zHyEfevH4X7VBh0xJQ/vD+g IoXS0Fay4++oI7ueFwQdw+X2VF/S+szYs5Nxe76g2kE75Q79Y9re7SWA/uuLHy7QpHfZ otGhyAZN6lUFN8kn43uwtMRT2W38fakeYZ3LuBZ0Jy1aG72reOo7MHh/InQOQgGQAGuZ GVMQ== X-Gm-Message-State: AOAM531Q8mTue7NbprbG656qcQNkplle3RP1Kg/ApZSNuYju3xqExfoZ rPbWTFCFV+fi3RIEsUgq1e8= X-Google-Smtp-Source: ABdhPJzGmGo4hVgp4N/WY3nd7t9HzRMJ+JwJopq0ualvFPzKUXHIONHyah7lUi4K93XC24ONCR48RA== X-Received: by 2002:a50:f10c:: with SMTP id w12mr430898edl.202.1596586323504; Tue, 04 Aug 2020 17:12:03 -0700 (PDT) Received: from skbuf ([188.26.57.97]) by smtp.gmail.com with ESMTPSA id m6sm310349ejq.85.2020.08.04.17.12.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2020 17:12:03 -0700 (PDT) Date: Wed, 5 Aug 2020 03:12:01 +0300 From: Vladimir Oltean To: Jacob Keller Cc: kuba@kernel.org, davem@davemloft.net, netdev@vger.kernel.org, richardcochran@gmail.com Subject: Re: [PATCH v2 net-next] ptp: only allow phase values lower than 1 period Message-ID: <20200805001201.v7idope4zidyi6st@skbuf> References: <20200804234308.1303022-1-olteanv@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Aug 04, 2020 at 05:04:47PM -0700, Jacob Keller wrote: > > A nit: this could read "therefore anything equal or larger than 1 period > is invalid"? a number modulo itself is 0, right? and we use ">=" below > as well now. > Thanks, I've corrected that too, now. -Vladimir