From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 687A3C433DF for ; Wed, 5 Aug 2020 18:23:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 436D322CA1 for ; Wed, 5 Aug 2020 18:23:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="Jmg3XGUX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729185AbgHESXX (ORCPT ); Wed, 5 Aug 2020 14:23:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728712AbgHESWy (ORCPT ); Wed, 5 Aug 2020 14:22:54 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B16F6C061575; Wed, 5 Aug 2020 11:22:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=wjGUmMwAwZVHBFBHwSRAPlWoXdzqfrdYlvMEZCahuMA=; b=Jmg3XGUXX1Sk+AH/bPxJUbHC9 85vLTxq6eqP0fNuvrSWRAGFdHwCQGF+BszQW/24v9HHpk05QTEZ0u9FghyxQ+Ve6JgtoHZOEwzegd eLbjLMsjytLiNSRro1Jv0I35rRqQbMjKwFP2Yu1oUPjY3/75L5CzhewAYIammS5nxIWmX98BTaj3x nH05ej6nyqL3jn51BozCTt4zLYPcstWPmvtV3bXCkHOTnelIydBH+482e3P8ZZ8fqUkcyYoeEXjNe wBIrLbOHezitiYtM4Z8Uk5lwJ45NkAkmNZJ/FzmTSaCpm9lDPmmAAHZMJW7ddeB3UPAGYPo2WZbjy 4AQ68jvwg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:48736) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k3O3w-0003n2-86; Wed, 05 Aug 2020 19:22:52 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1k3O3v-0005LP-0e; Wed, 05 Aug 2020 19:22:51 +0100 Date: Wed, 5 Aug 2020 19:22:50 +0100 From: Russell King - ARM Linux admin To: Linus Torvalds Cc: Linux Kernel Mailing List , Netdev Subject: Re: [PATCH] MAINTAINERS: update phylink/sfp keyword matching Message-ID: <20200805182250.GX1551@shell.armlinux.org.uk> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Aug 05, 2020 at 11:11:28AM -0700, Linus Torvalds wrote: > On Wed, Aug 5, 2020 at 7:34 AM Russell King wrote: > > > > Is this something you're willing to merge directly please? > > Done. > > That said: > > > -K: phylink > > +K: phylink\.h|struct\s+phylink|\.phylink|>phylink_|phylink_(autoneg|clear|connect|create|destroy|disconnect|ethtool|helper|mac|mii|of|set|start|stop|test|validate) > > That's a very awkward pattern. I wonder if there could be better ways > to express this (ie "only apply this pattern to these files" kind of > thing) Yes, it's extremely awkward - I spent much of the morning with perl testing it out on the drivers/ subtree. > Isn't the 'F' pattern already complete enough that maybe the K pattern > isn't even worth it? Unfortunately not; I used not to have a K: line, which presented the problem that we had users of phylink added to the kernel that were not being reviewed. So, the suggestion was to add a K: line. However, I'm now being spammed by syzbot (I've received multiple emails about the same problem) because, rather than MAINTAINERS being applied to just patches, it is now being applied to entire source files. This means that the previous "K: phylink" entry matches not just on patches (which can be easily ignored) but entire files, such as net/bluetooth/hci_event.c which happens to contain "phylink" in a function name. So, when syzbot identifies there is a problem in net/bluetooth/hci_event.c, it sends me a report, despite it having no relevance for me. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!