From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9EBDC433DF for ; Wed, 5 Aug 2020 22:12:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B87A42250E for ; Wed, 5 Aug 2020 22:12:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="eqLjHofl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726291AbgHEWMT (ORCPT ); Wed, 5 Aug 2020 18:12:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725730AbgHEWMS (ORCPT ); Wed, 5 Aug 2020 18:12:18 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34A89C061575; Wed, 5 Aug 2020 15:12:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=r6Geb4stpHL3cDqLdXNupy/tiwXhSJkV7V4CYHM4kNk=; b=eqLjHoflg7+HpgOSLLcIVhZPT rEG4aGu+zpYkpUFwZQKDN2PO89yy7N/pvif8JO22sMlhZK/FyE63/jCFaNZ9AAZw/6XhXiQWX171Q s9MpMuhJSdUeIelp0kGrtIioGy4SCrdTLohetdYGcO5egyVn25uGM5pcYPoEhGFEr1FTsVbWVWpC8 oxZivaSSePkdkYtjStYM2jczkcUDz/sXCy7T+WYvJlOePjxmmCUKoBnZEl0rIP8lyAm2y4MmnY04B gTStzSMm8zOQaAYASYwFnTOiRrBQ6nAtfQDJiN9glmPLXFee6zEBXBeNdCnV6Ao6MPOaj2qvWLh6g DGgnfsSFQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:48808) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k3Rdw-0003yN-Rx; Wed, 05 Aug 2020 23:12:16 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1k3Rdw-0005V1-Ky; Wed, 05 Aug 2020 23:12:16 +0100 Date: Wed, 5 Aug 2020 23:12:16 +0100 From: Russell King - ARM Linux admin To: Joe Perches Cc: Linus Torvalds , Linux Kernel Mailing List , Netdev Subject: Re: [PATCH] MAINTAINERS: update phylink/sfp keyword matching Message-ID: <20200805221216.GA1551@shell.armlinux.org.uk> References: <20200805182250.GX1551@shell.armlinux.org.uk> <8977553d1b52e567f72abc2ccad0eb5bca62e242.camel@perches.com> <20200805220215.GY1551@shell.armlinux.org.uk> <912b806b7943a227e3c79ed747b2242b87a3fd50.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <912b806b7943a227e3c79ed747b2242b87a3fd50.camel@perches.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Aug 05, 2020 at 03:09:34PM -0700, Joe Perches wrote: > On Wed, 2020-08-05 at 23:02 +0100, Russell King - ARM Linux admin wrote: > > On Wed, Aug 05, 2020 at 11:54:25AM -0700, Joe Perches wrote: > > > On Wed, 2020-08-05 at 19:22 +0100, Russell King - ARM Linux admin wrote: > > > > On Wed, Aug 05, 2020 at 11:11:28AM -0700, Linus Torvalds wrote: > > > > > On Wed, Aug 5, 2020 at 7:34 AM Russell King wrote: > > > > > > Is this something you're willing to merge directly please? > > > > > > > > > > Done. > > > > > > > > > > That said: > > > > > > > > > > > -K: phylink > > > > > > +K: phylink\.h|struct\s+phylink|\.phylink|>phylink_|phylink_(autoneg|clear|connect|create|destroy|disconnect|ethtool|helper|mac|mii|of|set|start|stop|test|validate) > > > > > > > > > > That's a very awkward pattern. I wonder if there could be better ways > > > > > to express this (ie "only apply this pattern to these files" kind of > > > > > thing) > > > > > > > > Yes, it's extremely awkward - I spent much of the morning with perl > > > > testing it out on the drivers/ subtree. > > > > > > And perhaps easier to read would be to use multiple K: lines. > > > (?: used to avoid unnecessary capture groups) > > > > > > K: phylink\.h|struct\s+phylink > > > K: (?:\.|\-\>)phylink_ > > > > That one is definitely incorrect. It is not .phylink_ or ->phylink_, > > it was .phylink (without _) or >phylink_ > > Hi Russell. > > I don't see the difference. > > All uses of .phylink are followed with _ > as far as I can tell. > > $ git grep -Poh "\.phylink\S*"|sort|uniq -c > 1 .phylink_fixed_state > 2 .phylink_mac_an_restart > 9 .phylink_mac_config > 1 .phylink_mac_config. > 11 .phylink_mac_link_down > 6 .phylink_mac_link_state > 9 .phylink_mac_link_up > 38 .phylink_validate Yes, you're right, but as I explained, I got something that works for me, and I wasn't going to put more effort in. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!