From: sdf@google.com
To: netdev@vger.kernel.org, bpf@vger.kernel.org
Cc: davem@davemloft.net, ast@kernel.org, daniel@iogearbox.net
Subject: Re: [PATCH bpf] bpf: add missing return to resolve_btfids
Date: Thu, 6 Aug 2020 11:22:09 -0700 [thread overview]
Message-ID: <20200806182209.GG184844@google.com> (raw)
In-Reply-To: <20200806155225.637202-1-sdf@google.com>
On 08/06, Stanislav Fomichev wrote:
> int sets_patch(struct object *obj) doesn't have a 'return 0' at the end.
> Signed-off-by: Stanislav Fomichev <sdf@google.com>
> ---
> tools/bpf/resolve_btfids/main.c | 1 +
> 1 file changed, 1 insertion(+)
> diff --git a/tools/bpf/resolve_btfids/main.c
> b/tools/bpf/resolve_btfids/main.c
> index 52d883325a23..4d9ecb975862 100644
> --- a/tools/bpf/resolve_btfids/main.c
> +++ b/tools/bpf/resolve_btfids/main.c
> @@ -566,6 +566,7 @@ static int sets_patch(struct object *obj)
> next = rb_next(next);
> }
> + return 0;
> }
> static int symbols_patch(struct object *obj)
> --
> 2.28.0.236.gb10cc79966-goog
Sorry, forgot:
Fixes: fbbb68de80a4 ("bpf: Add resolve_btfids tool to resolve BTF IDs in
ELF object")
next prev parent reply other threads:[~2020-08-06 18:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 15:52 [PATCH bpf] bpf: add missing return to resolve_btfids Stanislav Fomichev
2020-08-06 18:22 ` sdf [this message]
2020-08-06 23:52 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200806182209.GG184844@google.com \
--to=sdf@google.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).