* [PATCH bpf] bpf: add missing return to resolve_btfids
@ 2020-08-06 15:52 Stanislav Fomichev
2020-08-06 18:22 ` sdf
0 siblings, 1 reply; 3+ messages in thread
From: Stanislav Fomichev @ 2020-08-06 15:52 UTC (permalink / raw)
To: netdev, bpf; +Cc: davem, ast, daniel, Stanislav Fomichev
int sets_patch(struct object *obj) doesn't have a 'return 0' at the end.
Signed-off-by: Stanislav Fomichev <sdf@google.com>
---
tools/bpf/resolve_btfids/main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/bpf/resolve_btfids/main.c b/tools/bpf/resolve_btfids/main.c
index 52d883325a23..4d9ecb975862 100644
--- a/tools/bpf/resolve_btfids/main.c
+++ b/tools/bpf/resolve_btfids/main.c
@@ -566,6 +566,7 @@ static int sets_patch(struct object *obj)
next = rb_next(next);
}
+ return 0;
}
static int symbols_patch(struct object *obj)
--
2.28.0.236.gb10cc79966-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH bpf] bpf: add missing return to resolve_btfids
2020-08-06 15:52 [PATCH bpf] bpf: add missing return to resolve_btfids Stanislav Fomichev
@ 2020-08-06 18:22 ` sdf
2020-08-06 23:52 ` Alexei Starovoitov
0 siblings, 1 reply; 3+ messages in thread
From: sdf @ 2020-08-06 18:22 UTC (permalink / raw)
To: netdev, bpf; +Cc: davem, ast, daniel
On 08/06, Stanislav Fomichev wrote:
> int sets_patch(struct object *obj) doesn't have a 'return 0' at the end.
> Signed-off-by: Stanislav Fomichev <sdf@google.com>
> ---
> tools/bpf/resolve_btfids/main.c | 1 +
> 1 file changed, 1 insertion(+)
> diff --git a/tools/bpf/resolve_btfids/main.c
> b/tools/bpf/resolve_btfids/main.c
> index 52d883325a23..4d9ecb975862 100644
> --- a/tools/bpf/resolve_btfids/main.c
> +++ b/tools/bpf/resolve_btfids/main.c
> @@ -566,6 +566,7 @@ static int sets_patch(struct object *obj)
> next = rb_next(next);
> }
> + return 0;
> }
> static int symbols_patch(struct object *obj)
> --
> 2.28.0.236.gb10cc79966-goog
Sorry, forgot:
Fixes: fbbb68de80a4 ("bpf: Add resolve_btfids tool to resolve BTF IDs in
ELF object")
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH bpf] bpf: add missing return to resolve_btfids
2020-08-06 18:22 ` sdf
@ 2020-08-06 23:52 ` Alexei Starovoitov
0 siblings, 0 replies; 3+ messages in thread
From: Alexei Starovoitov @ 2020-08-06 23:52 UTC (permalink / raw)
To: Stanislav Fomichev
Cc: Network Development, bpf, David S. Miller, Alexei Starovoitov,
Daniel Borkmann
On Thu, Aug 6, 2020 at 11:22 AM <sdf@google.com> wrote:
>
> On 08/06, Stanislav Fomichev wrote:
> > int sets_patch(struct object *obj) doesn't have a 'return 0' at the end.
>
> > Signed-off-by: Stanislav Fomichev <sdf@google.com>
> > ---
> > tools/bpf/resolve_btfids/main.c | 1 +
> > 1 file changed, 1 insertion(+)
>
> > diff --git a/tools/bpf/resolve_btfids/main.c
> > b/tools/bpf/resolve_btfids/main.c
> > index 52d883325a23..4d9ecb975862 100644
> > --- a/tools/bpf/resolve_btfids/main.c
> > +++ b/tools/bpf/resolve_btfids/main.c
> > @@ -566,6 +566,7 @@ static int sets_patch(struct object *obj)
>
> > next = rb_next(next);
> > }
> > + return 0;
> > }
>
> > static int symbols_patch(struct object *obj)
> > --
> > 2.28.0.236.gb10cc79966-goog
>
> Sorry, forgot:
>
> Fixes: fbbb68de80a4 ("bpf: Add resolve_btfids tool to resolve BTF IDs in
> ELF object")
Applied. Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-06 23:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-06 15:52 [PATCH bpf] bpf: add missing return to resolve_btfids Stanislav Fomichev
2020-08-06 18:22 ` sdf
2020-08-06 23:52 ` Alexei Starovoitov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).