From: Jiri Olsa <jolsa@redhat.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andriin@fb.com>,
Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
Martin KaFai Lau <kafai@fb.com>, David Miller <davem@redhat.com>,
John Fastabend <john.fastabend@gmail.com>,
Wenbo Zhang <ethercflow@gmail.com>,
KP Singh <kpsingh@chromium.org>,
Brendan Gregg <bgregg@netflix.com>,
Florent Revest <revest@chromium.org>,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH v10 bpf-next 08/14] bpf: Add btf_struct_ids_match function
Date: Sun, 9 Aug 2020 16:47:06 +0200 [thread overview]
Message-ID: <20200809144706.GD619980@krava> (raw)
In-Reply-To: <CAEf4BzY8vE8k9c5fBB+3mcEpxOWc38dWBK8ji2aRpHM79nra_Q@mail.gmail.com>
On Fri, Aug 07, 2020 at 01:04:26PM -0700, Andrii Nakryiko wrote:
SNIP
> > + }
> > }
> > } else if (!fn->check_btf_id(reg->btf_id, arg)) {
>
> Put this on a wishlist for now. I don't think we should expect
> fb->check_btf_id() to do btf_struct_ids_match() internally, so to
> support this, we'd have to call fb->check_btf_id() inside the loop
> while doing WALK_STRUCT struct. But let's not change all this in this
> patch set, it's involved enough already.
>
> > verbose(env, "Helper does not support %s in R%d\n",
> > @@ -3977,7 +3982,8 @@ static int check_func_arg(struct bpf_verifier_env *env, u32 arg,
> >
> > return -EACCES;
> > }
> > - if (!tnum_is_const(reg->var_off) || reg->var_off.value || reg->off) {
> > + if (!ids_match &&
> > + (!tnum_is_const(reg->var_off) || reg->var_off.value || reg->off)) {
>
> Isn't this still wrong? if ids_match, but reg->var_off is non-zero,
> that's still bad, right?
> ids_match just "mitigates" reg->off check, so should be something like this:
>
> if ((reg->off && !ids_match) || !tnum_is_const(reg->var_off) ||
> reg->var_off.value)
> ... then bad ...
damn you're right, those are separated things,
I mixed it up, I'll send new version
thanks,
jirka
next prev parent reply other threads:[~2020-08-09 14:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 9:45 [PATCH v10 bpf-next 00/14] bpf: Add d_path helper Jiri Olsa
2020-08-07 9:45 ` [PATCH v10 bpf-next 01/14] tools resolve_btfids: Add size check to get_id function Jiri Olsa
2020-08-07 9:45 ` [PATCH v10 bpf-next 02/14] tools resolve_btfids: Add support for set symbols Jiri Olsa
2020-08-07 9:45 ` [PATCH v10 bpf-next 03/14] bpf: Move btf_resolve_size into __btf_resolve_size Jiri Olsa
2020-08-07 9:45 ` [PATCH v10 bpf-next 04/14] bpf: Add elem_id pointer as argument to __btf_resolve_size Jiri Olsa
2020-08-07 9:45 ` [PATCH v10 bpf-next 05/14] bpf: Add type_id " Jiri Olsa
2020-08-07 9:45 ` [PATCH v10 bpf-next 06/14] bpf: Remove recursion call in btf_struct_access Jiri Olsa
2020-08-07 9:45 ` [PATCH v10 bpf-next 07/14] bpf: Factor btf_struct_access function Jiri Olsa
2020-08-07 9:45 ` [PATCH v10 bpf-next 08/14] bpf: Add btf_struct_ids_match function Jiri Olsa
2020-08-07 20:04 ` Andrii Nakryiko
2020-08-09 14:47 ` Jiri Olsa [this message]
2020-08-07 9:45 ` [PATCH v10 bpf-next 09/14] bpf: Add BTF_SET_START/END macros Jiri Olsa
2020-08-07 9:45 ` [PATCH v10 bpf-next 10/14] bpf: Add d_path helper Jiri Olsa
2020-08-07 20:05 ` Andrii Nakryiko
2020-08-07 9:45 ` [PATCH v10 bpf-next 11/14] bpf: Update .BTF_ids section in btf.rst with sets info Jiri Olsa
2020-08-07 20:05 ` Andrii Nakryiko
2020-08-07 9:45 ` [PATCH v10 bpf-next 12/14] selftests/bpf: Add verifier test for d_path helper Jiri Olsa
2020-08-07 9:45 ` [PATCH v10 bpf-next 13/14] selftests/bpf: Add " Jiri Olsa
2020-08-07 9:45 ` [PATCH v10 bpf-next 14/14] selftests/bpf: Add set test to resolve_btfids Jiri Olsa
2020-08-07 16:35 ` [PATCH v10 bpf-next 00/14] bpf: Add d_path helper Alexei Starovoitov
2020-08-07 17:25 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200809144706.GD619980@krava \
--to=jolsa@redhat.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bgregg@netflix.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@redhat.com \
--cc=ethercflow@gmail.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=netdev@vger.kernel.org \
--cc=revest@chromium.org \
--cc=songliubraving@fb.com \
--cc=viro@zeniv.linux.org.uk \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).