From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4FBDC433DF for ; Mon, 10 Aug 2020 13:57:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CE4952078E for ; Mon, 10 Aug 2020 13:57:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726977AbgHJN5M (ORCPT ); Mon, 10 Aug 2020 09:57:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726584AbgHJN5L (ORCPT ); Mon, 10 Aug 2020 09:57:11 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62322C061756; Mon, 10 Aug 2020 06:57:11 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1k58I5-0002a7-W0; Mon, 10 Aug 2020 15:56:42 +0200 Date: Mon, 10 Aug 2020 15:56:41 +0200 From: Florian Westphal To: Miaohe Lin Cc: davem@davemloft.net, kuba@kernel.org, pshelar@ovn.org, martin.varghese@nokia.com, fw@strlen.de, dcaratti@redhat.com, edumazet@google.com, steffen.klassert@secunet.com, pabeni@redhat.com, shmulik@metanetworks.com, kyk.segfault@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: eliminate meaningless memcpy to data in pskb_carve_inside_nonlinear() Message-ID: <20200810135641.GE19310@breakpoint.cc> References: <20200810122856.5423-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200810122856.5423-1-linmiaohe@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Miaohe Lin wrote: > The skb_shared_info part of the data is assigned in the following loop. Where?