From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26063C433E0 for ; Mon, 10 Aug 2020 14:12:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0D3DE2076B for ; Mon, 10 Aug 2020 14:12:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726998AbgHJOMY (ORCPT ); Mon, 10 Aug 2020 10:12:24 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:48710 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726814AbgHJOMX (ORCPT ); Mon, 10 Aug 2020 10:12:23 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1k58XG-008xBZ-PC; Mon, 10 Aug 2020 16:12:22 +0200 Date: Mon, 10 Aug 2020 16:12:22 +0200 From: Andrew Lunn To: Michal Kubecek Cc: netdev@vger.kernel.org Subject: Re: [PATCH ethtool 2/7] ioctl: check presence of eeprom length argument properly Message-ID: <20200810141222.GE2123435@lunn.ch> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Aug 09, 2020 at 11:24:22PM +0200, Michal Kubecek wrote: > In do_geeprom(), do_seprom() and do_getmodule(), check if user used > "length" command line argument is done by setting the value to -1 before > parsing and checking if it changed. This is quite ugly and also causes > compiler warnings as the variable is u32. > > Use proper "seen" flag to let parser tell us if the argument was used. > > Signed-off-by: Michal Kubecek Reviewed-by: Andrew Lunn Andrew