From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 164C9C433DF for ; Mon, 10 Aug 2020 14:19:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EBFCB2070B for ; Mon, 10 Aug 2020 14:19:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727010AbgHJOT0 (ORCPT ); Mon, 10 Aug 2020 10:19:26 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:48724 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726845AbgHJOTZ (ORCPT ); Mon, 10 Aug 2020 10:19:25 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1k58e4-008xDo-A0; Mon, 10 Aug 2020 16:19:24 +0200 Date: Mon, 10 Aug 2020 16:19:24 +0200 From: Andrew Lunn To: Michal Kubecek Cc: netdev@vger.kernel.org Subject: Re: [PATCH ethtool 3/7] ioctl: get rid of signed/unsigned comparison warnings Message-ID: <20200810141924.GF2123435@lunn.ch> References: <0365573afe3649e47c1aa2490e1818a50613ee0a.1597007533.git.mkubecek@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0365573afe3649e47c1aa2490e1818a50613ee0a.1597007533.git.mkubecek@suse.cz> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > - while (arg_num < ctx->argc) { > + while (arg_num < (unsigned int)ctx->argc) { Did you try changing ctx->argc to an unsigned int? I guess there would be less casts that way, and it is a more logical type for this. Andrew