From: Ido Schimmel <idosch@idosch.org>
To: Adrian Pop <popadrian1996@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
jiri@mellanox.com, vadimp@mellanox.com, andrew@lunn.ch,
mlxsw@mellanox.com, idosch@mellanox.com, roopa@nvidia.com,
paschmidt@nvidia.com
Subject: Re: [PATCH ethtool v3] Add QSFP-DD support
Date: Thu, 13 Aug 2020 12:24:02 +0300 [thread overview]
Message-ID: <20200813092402.GA3426088@shredder> (raw)
In-Reply-To: <20200813071735.7970-1-popadrian1996@gmail.com>
On Thu, Aug 13, 2020 at 10:17:35AM +0300, Adrian Pop wrote:
> The Common Management Interface Specification (CMIS) for QSFP-DD shares
> some similarities with other form factors such as QSFP or SFP, but due to
> the fact that the module memory map is different, the current ethtool
> version is not able to provide relevant information about an interface.
>
> This patch adds QSFP-DD support to ethtool. The changes are similar to
> the ones already existing in qsfp.c, but customized to use the memory
> addresses and logic as defined in the specifications document.
>
> Several functions from qsfp.c could be reused, so an additional parameter
> was added to each and the functions were moved to sff-common.c.
>
> Changelog (diff from v2):
> * Remove functions assuming the existance of page 0x10 and 0x11
> * Remove structs and constants related to the page 0x10 and 0x11
Adrian, you're missing diff from v1 and Signed-off-by tag.
Please send v4 with these changes.
And please CC Michal Kubecek <mkubecek@suse.cz> on ethtool patches since
he maintains the tool.
Thanks
> ---
next prev parent reply other threads:[~2020-08-13 9:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 7:17 [PATCH ethtool v3] Add QSFP-DD support Adrian Pop
2020-08-13 9:24 ` Ido Schimmel [this message]
2020-08-13 7:38 ` Adrian Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200813092402.GA3426088@shredder \
--to=idosch@idosch.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=kuba@kernel.org \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=paschmidt@nvidia.com \
--cc=popadrian1996@gmail.com \
--cc=roopa@nvidia.com \
--cc=vadimp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox