From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88871C433E3 for ; Fri, 14 Aug 2020 14:48:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5AB2E20855 for ; Fri, 14 Aug 2020 14:48:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="C6O0gpj0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728276AbgHNOr7 (ORCPT ); Fri, 14 Aug 2020 10:47:59 -0400 Received: from mail29.static.mailgun.info ([104.130.122.29]:60288 "EHLO mail29.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726270AbgHNOr7 (ORCPT ); Fri, 14 Aug 2020 10:47:59 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1597416478; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=5bjxNb/F89xa7CS6S3NOKLAf9mAo71elY+kX0Y7RX0c=; b=C6O0gpj0ttEdlc+XXEqkC1D3tyzWVNzrmF83J9VQt69FV5NH4fe7Ipx2YwZMlpViwlYWL7IL wih4xpmisP9KzCLsvmRZm8ofnRoddtusMy75zeO+2XbOBNC2azhsc7rZRpjap0QUbwEV/0So CyMD9JUIdCyebjREyQ2+fM1AMG0= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyJiZjI2MiIsICJuZXRkZXZAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-east-1.postgun.com with SMTP id 5f36a40ed48d4625cad9f375 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 14 Aug 2020 14:47:42 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id DB6D4C43391; Fri, 14 Aug 2020 14:47:41 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 71A77C433C6; Fri, 14 Aug 2020 14:47:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 71A77C433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH][next] wil6210: Avoid the use of one-element array From: Kalle Valo In-Reply-To: <20200715215755.GA21716@embeddedor> References: <20200715215755.GA21716@embeddedor> To: "Gustavo A. R. Silva" Cc: Maya Erez , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20200814144741.DB6D4C43391@smtp.codeaurora.org> Date: Fri, 14 Aug 2020 14:47:41 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org "Gustavo A. R. Silva" wrote: > One-element arrays are being deprecated[1]. Replace the one-element > array with a simple value type 'u8 reserved'[2], once this is just > a placeholder for alignment. > > [1] https://github.com/KSPP/linux/issues/79 > [2] https://github.com/KSPP/linux/issues/86 > > Tested-by: kernel test robot > Link: https://github.com/GustavoARSilva/linux-hardening/blob/master/cii/0-day/wil6210-20200715.md > Signed-off-by: Gustavo A. R. Silva > Signed-off-by: Kalle Valo I agree with Johannes, I don't see the point of this patch as there are no clear benefits. Patch set to Rejected. -- https://patchwork.kernel.org/patch/11666325/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches