From: Kalle Valo <kvalo@codeaurora.org>
To: Julia Lawall <Julia.Lawall@inria.fr>
Cc: kernel-janitors@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/7] ath: drop unnecessary list_empty
Date: Fri, 14 Aug 2020 15:05:22 +0000 (UTC) [thread overview]
Message-ID: <20200814150522.C0936C43391@smtp.codeaurora.org> (raw)
In-Reply-To: <1595761112-11003-8-git-send-email-Julia.Lawall@inria.fr>
Julia Lawall <Julia.Lawall@inria.fr> wrote:
> list_for_each_entry{_safe} is able to handle an empty list.
> The only effect of avoiding the loop is not initializing the
> index variable.
> Drop list_empty tests in cases where these variables are not
> used.
>
> Note that list_for_each_entry{_safe} is defined in terms of
> list_first_entry, which indicates that it should not be used on an
> empty list. But in list_for_each_entry{_safe}, the element obtained
> by list_first_entry is not really accessed, only the address of its
> list_head field is compared to the address of the list head, so the
> list_first_entry is safe.
>
> The semantic patch that makes this change for the list_for_each_entry
> case is as follows: (http://coccinelle.lip6.fr/)
>
> <smpl>
> @@
> expression x,e;
> statement S;
> identifier i;
> @@
>
> -if (!(list_empty(x)))
> list_for_each_entry(i,x,...) S
> ... when != i
> ? i = e
> </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
18c25b4019ca ath: drop unnecessary list_empty
--
https://patchwork.kernel.org/patch/11685677/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-08-14 15:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-26 10:58 [PATCH 0/7] drop unnecessary list_empty Julia Lawall
2020-07-26 10:58 ` [PATCH 2/7] sfc: " Julia Lawall
2020-07-27 12:13 ` Edward Cree
2020-07-27 17:10 ` David Miller
2020-07-26 10:58 ` [PATCH 4/7] net/mlx5: " Julia Lawall
2020-07-27 17:10 ` David Miller
2020-07-28 7:53 ` Saeed Mahameed
2020-07-26 10:58 ` [PATCH 7/7] ath: " Julia Lawall
2020-08-14 15:05 ` Kalle Valo [this message]
2020-07-30 22:28 ` [PATCH 0/7] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200814150522.C0936C43391@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=Julia.Lawall@inria.fr \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).