From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=H3rr=B2=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS
	autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 4E11DC433DF
	for <netdev@archiver.kernel.org>; Sun, 16 Aug 2020 22:16:21 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 311C82078D
	for <netdev@archiver.kernel.org>; Sun, 16 Aug 2020 22:16:21 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1729467AbgHPWQU (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Sun, 16 Aug 2020 18:16:20 -0400
Received: from vps0.lunn.ch ([185.16.172.187]:55624 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1728057AbgHPWQU (ORCPT <rfc822;netdev@vger.kernel.org>);
        Sun, 16 Aug 2020 18:16:20 -0400
Received: from andrew by vps0.lunn.ch with local (Exim 4.94)
        (envelope-from <andrew@lunn.ch>)
        id 1k7Qws-009dEk-Lh; Mon, 17 Aug 2020 00:16:18 +0200
Date:   Mon, 17 Aug 2020 00:16:18 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Vladimir Oltean <olteanv@gmail.com>
Cc:     David Miller <davem@davemloft.net>,
        netdev <netdev@vger.kernel.org>, Chris Healy <cphealy@gmail.com>,
        Vivien Didelot <vivien.didelot@gmail.com>
Subject: Re: [PATCH net-next 6/7] net: dsa: wire up devlink info get
Message-ID: <20200816221618.GB2294711@lunn.ch>
References: <20200816194316.2291489-1-andrew@lunn.ch>
 <20200816194316.2291489-7-andrew@lunn.ch>
 <20200816215630.l7rdynh4ymx426uq@skbuf>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200816215630.l7rdynh4ymx426uq@skbuf>
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

> > +static int dsa_devlink_info_get(struct devlink *dl,
> > +				struct devlink_info_req *req,
> > +				struct netlink_ext_ack *extack)
> > +{
> > +	struct dsa_switch *ds;
> > +
> > +	ds = dsa_devlink_to_ds(dl);
> > +
> 
> Why not place the declaration and the assignment on a single line?

This code went through a few refactors. Probably at some point i could
not keep reverse christmass tree so had to split it. And it then never
got put back together again.

I will fix it up for v2.

  Andrew