From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Edward Cree <ecree@solarflare.com>
Cc: <linux-net-drivers@solarflare.com>, <davem@davemloft.net>,
<netdev@vger.kernel.org>
Subject: Re: [PATCH net 3/4] sfc: null out channel->rps_flow_id after freeing it
Date: Tue, 18 Aug 2020 12:01:37 -0700 [thread overview]
Message-ID: <20200818120137.00004035@intel.com> (raw)
In-Reply-To: <20200818115857.000078e5@intel.com>
Jesse Brandeburg wrote:
> Edward Cree wrote:
>
> > If an ef100_net_open() fails, ef100_net_stop() may be called without
> > channel->rps_flow_id having been written; thus it may hold the address
> > freed by a previous ef100_net_stop()'s call to efx_remove_filters().
> > This then causes a double-free when efx_remove_filters() is called
> > again, leading to a panic.
> > To prevent this, after freeing it, overwrite it with NULL.
> >
> > Fixes: a9dc3d5612ce ("sfc_ef100: RX filter table management and related gubbins")
> > Signed-off-by: Edward Cree <ecree@solarflare.com>
My mailer messed up my previous reply, but this is what I meant to say:
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
next prev parent reply other threads:[~2020-08-18 19:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 12:41 [PATCH net 0/4] sfc: more EF100 fixes Edward Cree
2020-08-18 12:43 ` [PATCH net 1/4] sfc: really check hash is valid before using it Edward Cree
2020-08-18 18:54 ` Jesse Brandeburg
2020-08-18 12:43 ` [PATCH net 2/4] sfc: take correct lock in ef100_reset() Edward Cree
2020-08-18 18:55 ` Jesse Brandeburg
2020-08-18 12:44 ` [PATCH net 3/4] sfc: null out channel->rps_flow_id after freeing it Edward Cree
2020-08-18 18:58 ` Jesse Brandeburg
2020-08-18 19:01 ` Jesse Brandeburg [this message]
2020-08-18 12:44 ` [PATCH net 4/4] sfc: don't free_irq()s if they were never requested Edward Cree
2020-08-18 19:03 ` Jesse Brandeburg
2020-08-18 19:49 ` [PATCH net 0/4] sfc: more EF100 fixes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200818120137.00004035@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).