netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: peterz@infradead.org
To: Marco Elver <elver@google.com>
Cc: linux-kernel@vger.kernel.org, davem@davemloft.net,
	kuba@kernel.org, netdev@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>,
	Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH] random32: Use rcuidle variant for tracepoint
Date: Fri, 21 Aug 2020 10:59:07 +0200	[thread overview]
Message-ID: <20200821085907.GJ1362448@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20200821063043.1949509-1-elver@google.com>

On Fri, Aug 21, 2020 at 08:30:43AM +0200, Marco Elver wrote:
> With KCSAN enabled, prandom_u32() may be called from any context,
> including idle CPUs.
> 
> Therefore, switch to using trace_prandom_u32_rcuidle(), to avoid various
> issues due to recursion and lockdep warnings when KCSAN and tracing is
> enabled.

At some point we're going to have to introduce noinstr to idle as well.
But until that time this should indeed cure things.

  parent reply	other threads:[~2020-08-21  8:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-21  6:30 [PATCH] random32: Use rcuidle variant for tracepoint Marco Elver
2020-08-21  8:58 ` Marco Elver
2020-08-21  8:59 ` peterz [this message]
2020-08-21 15:06   ` Eric Dumazet
2020-08-21 15:35     ` Marco Elver
2020-09-18  1:21       ` Steven Rostedt
2020-08-21 15:38     ` Steven Rostedt
2020-08-21 15:41       ` Steven Rostedt
2020-08-21 18:38         ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200821085907.GJ1362448@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=elver@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).