From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Igor Russkikh <irusskikh@marvell.com>
Cc: <netdev@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Ariel Elior <aelior@marvell.com>,
Michal Kalderon <mkalderon@marvell.com>
Subject: Re: [PATCH net-next 00/11] qed: introduce devlink health support
Date: Fri, 21 Aug 2020 10:54:51 -0700 [thread overview]
Message-ID: <20200821105451.000052b9@intel.com> (raw)
In-Reply-To: <20200727184310.462-1-irusskikh@marvell.com>
Igor Russkikh wrote:
> This is a followup implementation after series
>
> https://patchwork.ozlabs.org/project/netdev/cover/20200514095727.1361-1-irusskikh@marvell.com/
>
> This is an implementation of devlink health infrastructure.
>
> With this we are now able to report HW errors to devlink, and it'll take
> its own actions depending on user configuration to capture and store the dump
> at the bad moment, and to request the driver to recover the device.
>
> So far we do not differentiate global device failures or specific PCI function
> failures. This means that some errors specific to one physical function will
> affect an entire device. This is not yet fully designed and verified, will
> followup in future.
>
> Solution was verified with artificial HW errors generated, existing tools
> for dump analysis could be used.
>
> Igor Russkikh (11):
> qed: move out devlink logic into a new file
> qed/qede: make devlink survive recovery
> qed: swap param init and publish
> qed: fix kconfig help entries
> qed: implement devlink info request
> qed: health reporter init deinit seq
> qed: use devlink logic to report errors
> qed*: make use of devlink recovery infrastructure
> qed: implement devlink dump
> qed: align adjacent indent
> qede: make driver reliable on unload after failures
>
> drivers/net/ethernet/qlogic/Kconfig | 5 +-
> drivers/net/ethernet/qlogic/qed/Makefile | 1 +
> drivers/net/ethernet/qlogic/qed/qed.h | 3 +-
> drivers/net/ethernet/qlogic/qed/qed_dev.c | 10 +
> drivers/net/ethernet/qlogic/qed/qed_devlink.c | 255 ++++++++++++++++++
> drivers/net/ethernet/qlogic/qed/qed_devlink.h | 20 ++
> drivers/net/ethernet/qlogic/qed/qed_main.c | 116 +-------
> drivers/net/ethernet/qlogic/qede/qede.h | 2 +
> drivers/net/ethernet/qlogic/qede/qede_main.c | 35 ++-
> include/linux/qed/qed_if.h | 23 +-
> 10 files changed, 341 insertions(+), 129 deletions(-)
> create mode 100644 drivers/net/ethernet/qlogic/qed/qed_devlink.c
> create mode 100644 drivers/net/ethernet/qlogic/qed/qed_devlink.h
I just realized I was reviewing this old set (somehow my mailer put this
one after the v6 in the message order) #reviewfail
I'll move over to v6 now, sorry for the thrash.
prev parent reply other threads:[~2020-08-21 17:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 18:42 [PATCH net-next 00/11] qed: introduce devlink health support Igor Russkikh
2020-07-27 18:43 ` [PATCH net-next 01/11] qed: move out devlink logic into a new file Igor Russkikh
2020-08-21 17:32 ` Jesse Brandeburg
2020-07-27 18:43 ` [PATCH net-next 02/11] qed/qede: make devlink survive recovery Igor Russkikh
2020-08-21 17:28 ` Jesse Brandeburg
2020-07-27 18:43 ` [PATCH net-next 03/11] qed: swap param init and publish Igor Russkikh
2020-08-21 17:33 ` Jesse Brandeburg
2020-07-27 18:43 ` [PATCH net-next 04/11] qed: fix kconfig help entries Igor Russkikh
2020-08-21 17:34 ` Jesse Brandeburg
2020-07-27 18:43 ` [PATCH net-next 05/11] qed: implement devlink info request Igor Russkikh
2020-08-21 17:42 ` Jesse Brandeburg
2020-07-27 18:43 ` [PATCH net-next 06/11] qed: health reporter init deinit seq Igor Russkikh
2020-08-21 17:46 ` Jesse Brandeburg
2020-07-27 18:43 ` [PATCH net-next 07/11] qed: use devlink logic to report errors Igor Russkikh
2020-08-21 17:49 ` Jesse Brandeburg
2020-07-27 18:43 ` [PATCH net-next 08/11] qed*: make use of devlink recovery infrastructure Igor Russkikh
2020-07-27 18:43 ` [PATCH net-next 09/11] qed: implement devlink dump Igor Russkikh
2020-07-27 20:40 ` kernel test robot
2020-07-27 18:43 ` [PATCH net-next 10/11] qed: align adjacent indent Igor Russkikh
2020-07-27 18:43 ` [PATCH net-next 11/11] qede: make driver reliable on unload after failures Igor Russkikh
2020-08-21 17:54 ` Jesse Brandeburg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200821105451.000052b9@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=aelior@marvell.com \
--cc=davem@davemloft.net \
--cc=irusskikh@marvell.com \
--cc=kuba@kernel.org \
--cc=mkalderon@marvell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).