From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A42E5C433E1 for ; Sun, 23 Aug 2020 20:08:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8654C206B5 for ; Sun, 23 Aug 2020 20:08:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726765AbgHWUI3 (ORCPT ); Sun, 23 Aug 2020 16:08:29 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:40796 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725887AbgHWUI2 (ORCPT ); Sun, 23 Aug 2020 16:08:28 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1k9wHz-00BQsM-98; Sun, 23 Aug 2020 22:08:27 +0200 Date: Sun, 23 Aug 2020 22:08:27 +0200 From: Andrew Lunn To: Michal Kubecek Cc: netdev@vger.kernel.org Subject: Re: [PATCH ethtool v2 4/9] ioctl: make argc counters unsigned Message-ID: <20200823200827.GI2588906@lunn.ch> References: <7bf829e6ec7b80b6a4e69cf59f54a36b1934fab9.1598210544.git.mkubecek@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7bf829e6ec7b80b6a4e69cf59f54a36b1934fab9.1598210544.git.mkubecek@suse.cz> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Aug 23, 2020 at 09:40:27PM +0200, Michal Kubecek wrote: > Use unsigned int for cmd_context::argc and local variables used for > command line argument count. These counters may never get negative and are > often compared to unsigned expressions. > > Signed-off-by: Michal Kubecek Reviewed-by: Andrew Lunn Andrew