From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3950C433DF for ; Thu, 27 Aug 2020 10:19:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C42C82075B for ; Thu, 27 Aug 2020 10:19:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="UXGZKPpl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728657AbgH0KTJ (ORCPT ); Thu, 27 Aug 2020 06:19:09 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:12001 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728849AbgH0KTE (ORCPT ); Thu, 27 Aug 2020 06:19:04 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1598523544; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=QbKK+5+ggvjqHyMHZ4elMsujh+LOHuTBEDXE/1UtSuQ=; b=UXGZKPplcn4QRgBk9qYnplwqJNCCme+QzoiXMgk0LPGhCYlwbQTE8nGoQgjtTPHmyLaWo17r jzbh+hEds+f0jf1GS5MW+1xCXRm2By+8KzIH8NWZUnVhnBuv3ld548bRHmqOscvw8OfwdZRS I4e7FVLgJodKxG4ajzfIVmnJwvk= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyJiZjI2MiIsICJuZXRkZXZAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-west-2.postgun.com with SMTP id 5f478897c598aced5430085c (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 27 Aug 2020 10:19:03 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 970DAC433AD; Thu, 27 Aug 2020 10:19:03 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id C3B27C433CB; Thu, 27 Aug 2020 10:19:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C3B27C433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] ath11k: return error if firmware request fails From: Kalle Valo In-Reply-To: <20200825143040.233619-1-alex.dewar90@gmail.com> References: <20200825143040.233619-1-alex.dewar90@gmail.com> To: Alex Dewar Cc: unlisted-recipients:; (no To-header on input) Alex Dewar , "David S. Miller" , Jakub Kicinski , ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Illegal-Object: Syntax error in Cc: address found on vger.kernel.org: Cc: unlisted-recipients:; (no To-header on input)Alex Dewar ^-missing end of address User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20200827101903.970DAC433AD@smtp.codeaurora.org> Date: Thu, 27 Aug 2020 10:19:03 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Alex Dewar wrote: > In ath11k_qmi_prepare_bdf_download(), ath11k_core_firmware_request() is > called, but the returned pointer is not checked for errors. Rather the > variable ret (which will always be zero) is checked by mistake. Fix > this and replace the various gotos with simple returns for clarity. > > While we are at it, move the call to memset, as variable bd is not used > on all code paths. > > Fixes: 7b57b2ddec21 ("ath11k: create a common function to request all firmware files") > Signed-off-by: Alex Dewar > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 342b6194a75b ath11k: return error if firmware request fails -- https://patchwork.kernel.org/patch/11735787/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches