From: Kalle Valo <kvalo@codeaurora.org>
To: Maximilian Luz <luzmaximilian@gmail.com>
Cc: unlisted-recipients:; (no To-header on input) Amitkumar Karwar
<amitkarwar@gmail.com>, Ganapathi Bhat <ganapathi.bhat@nxp.com>,
Xinming Hu <huxinming820@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Maximilian Luz <luzmaximilian@gmail.com>,
Kaloyan Nikolov <konik98@gmail.com>
Subject: Re: [net] mwifiex: Increase AES key storage size to 256 bits
Date: Thu, 27 Aug 2020 13:16:38 +0000 (UTC) [thread overview]
Message-ID: <20200827131638.5DCFFC433CA@smtp.codeaurora.org> (raw)
In-Reply-To: <20200825153829.38043-1-luzmaximilian@gmail.com>
Maximilian Luz <luzmaximilian@gmail.com> wrote:
> Following commit e18696786548 ("mwifiex: Prevent memory corruption
> handling keys") the mwifiex driver fails to authenticate with certain
> networks, specifically networks with 256 bit keys, and repeatedly asks
> for the password. The kernel log repeats the following lines (id and
> bssid redacted):
>
> mwifiex_pcie 0000:01:00.0: info: trying to associate to '<id>' bssid <bssid>
> mwifiex_pcie 0000:01:00.0: info: associated to bssid <bssid> successfully
> mwifiex_pcie 0000:01:00.0: crypto keys added
> mwifiex_pcie 0000:01:00.0: info: successfully disconnected from <bssid>: reason code 3
>
> Tracking down this problem lead to the overflow check introduced by the
> aforementioned commit into mwifiex_ret_802_11_key_material_v2(). This
> check fails on networks with 256 bit keys due to the current storage
> size for AES keys in struct mwifiex_aes_param being only 128 bit.
>
> To fix this issue, increase the storage size for AES keys to 256 bit.
>
> Fixes: e18696786548 ("mwifiex: Prevent memory corruption handling keys")
> Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>
> Reported-by: Kaloyan Nikolov <konik98@gmail.com>
> Tested-by: Kaloyan Nikolov <konik98@gmail.com>
> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
> Reviewed-by: Brian Norris <briannorris@chromium.org>
> Tested-by: Brian Norris <briannorris@chromium.org>
Patch applied to wireless-drivers.git, thanks.
4afc850e2e9e mwifiex: Increase AES key storage size to 256 bits
--
https://patchwork.kernel.org/patch/11735929/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2020-08-27 14:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 15:38 [PATCH net] mwifiex: Increase AES key storage size to 256 bits Maximilian Luz
2020-08-25 18:51 ` Dan Carpenter
2020-08-25 20:17 ` Maximilian Luz
2020-08-25 19:30 ` Brian Norris
2020-08-25 20:18 ` Maximilian Luz
2020-08-27 8:02 ` Kalle Valo
2020-08-27 13:16 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200827131638.5DCFFC433CA@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=luzmaximilian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).