From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 517DEC433E3 for ; Thu, 27 Aug 2020 14:53:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2820A22B4B for ; Thu, 27 Aug 2020 14:53:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="IT+rTL9u" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727031AbgH0NSp (ORCPT ); Thu, 27 Aug 2020 09:18:45 -0400 Received: from mail29.static.mailgun.info ([104.130.122.29]:51085 "EHLO mail29.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727769AbgH0NRR (ORCPT ); Thu, 27 Aug 2020 09:17:17 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1598534236; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=qjM5TvevdF5BS4WxhbMS1yvGeMjUtBBsveQHXqbPgr0=; b=IT+rTL9uKfyxHm4xYZom/bgNKNKd42hY++DPiUNeP4EaTKwyz7O57jj1CzJ45kNSk8G3TaDq uLl6TL0Q4EZvghqifWbdvjXzxP29oIIjD5ueIZjR3dpDK7epa3YxBdhCuppQTeL/FjYXWbfy UzanGhxgSJFva1mgymS11keqpQU= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyJiZjI2MiIsICJuZXRkZXZAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-west-2.postgun.com with SMTP id 5f47b23615988fabe06c04de (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 27 Aug 2020 13:16:38 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 5DCFFC433CA; Thu, 27 Aug 2020 13:16:38 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 11869C433CA; Thu, 27 Aug 2020 13:16:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 11869C433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [net] mwifiex: Increase AES key storage size to 256 bits From: Kalle Valo In-Reply-To: <20200825153829.38043-1-luzmaximilian@gmail.com> References: <20200825153829.38043-1-luzmaximilian@gmail.com> To: Maximilian Luz Cc: unlisted-recipients:; (no To-header on input) Amitkumar Karwar , Ganapathi Bhat , Xinming Hu , "David S. Miller" , Jakub Kicinski , Dan Carpenter , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Maximilian Luz , Kaloyan Nikolov Illegal-Object: Syntax error in Cc: address found on vger.kernel.org: Cc: unlisted-recipients:; (no To-header on input)Amitkumar Karwar ^-missing end of address User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20200827131638.5DCFFC433CA@smtp.codeaurora.org> Date: Thu, 27 Aug 2020 13:16:38 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Maximilian Luz wrote: > Following commit e18696786548 ("mwifiex: Prevent memory corruption > handling keys") the mwifiex driver fails to authenticate with certain > networks, specifically networks with 256 bit keys, and repeatedly asks > for the password. The kernel log repeats the following lines (id and > bssid redacted): > > mwifiex_pcie 0000:01:00.0: info: trying to associate to '' bssid > mwifiex_pcie 0000:01:00.0: info: associated to bssid successfully > mwifiex_pcie 0000:01:00.0: crypto keys added > mwifiex_pcie 0000:01:00.0: info: successfully disconnected from : reason code 3 > > Tracking down this problem lead to the overflow check introduced by the > aforementioned commit into mwifiex_ret_802_11_key_material_v2(). This > check fails on networks with 256 bit keys due to the current storage > size for AES keys in struct mwifiex_aes_param being only 128 bit. > > To fix this issue, increase the storage size for AES keys to 256 bit. > > Fixes: e18696786548 ("mwifiex: Prevent memory corruption handling keys") > Signed-off-by: Maximilian Luz > Reported-by: Kaloyan Nikolov > Tested-by: Kaloyan Nikolov > Reviewed-by: Dan Carpenter > Reviewed-by: Brian Norris > Tested-by: Brian Norris Patch applied to wireless-drivers.git, thanks. 4afc850e2e9e mwifiex: Increase AES key storage size to 256 bits -- https://patchwork.kernel.org/patch/11735929/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches