From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: wenxu@ucloud.cn, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] ipv6: add ipv6_fragment hook in ipv6_stub
Date: Thu, 27 Aug 2020 19:38:36 -0300 [thread overview]
Message-ID: <20200827223836.GB2443@localhost.localdomain> (raw)
In-Reply-To: <20200827.075147.1030378285544511842.davem@davemloft.net>
On Thu, Aug 27, 2020 at 07:51:47AM -0700, David Miller wrote:
> From: wenxu@ucloud.cn
> Date: Thu, 27 Aug 2020 18:39:51 +0800
>
> > From: wenxu <wenxu@ucloud.cn>
> >
> > Add ipv6_fragment to ipv6_stub to avoid calling netfilter when
> > access ip6_fragment.
> >
> > Signed-off-by: wenxu <wenxu@ucloud.cn>
>
> Please test these changes with ipv6 disabled.
>
> It will crash, you have to update the default stub in
> net/ipv6/addrconf_core.c as well.
I didn't test it myself but I'm not seeing how the crash could happen.
The next patch does check for it being NULL before using it:
- if (!v6ops)
+ if (!ipv6_stub->ipv6_fragment)
goto err;
Wenxu?
Marcelo
next prev parent reply other threads:[~2020-08-27 22:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 10:39 [PATCH net-next 0/2] Put ip6_fragment in ipv6_stub wenxu
2020-08-27 10:39 ` [PATCH net-next 1/2] ipv6: add ipv6_fragment hook " wenxu
2020-08-27 14:51 ` David Miller
2020-08-27 22:38 ` Marcelo Ricardo Leitner [this message]
2020-08-27 23:33 ` wenxu
2020-08-27 10:39 ` [PATCH net-next 2/2] openvswitch: using ip6_fragment " wenxu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200827223836.GB2443@localhost.localdomain \
--to=marcelo.leitner@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=wenxu@ucloud.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox