From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8B7DC433E6 for ; Fri, 28 Aug 2020 10:57:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AFBDF212CC for ; Fri, 28 Aug 2020 10:57:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="W2SRH6AO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728690AbgH1K5q (ORCPT ); Fri, 28 Aug 2020 06:57:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729051AbgH1K4O (ORCPT ); Fri, 28 Aug 2020 06:56:14 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DEEFC061236; Fri, 28 Aug 2020 03:54:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=VvK78WVDOB3813Y9VLnOVQrDFYwjVa9aFCav/Nofmnw=; b=W2SRH6AOPaKUfD9lJTMH/8ZOW 1iE6bQ42dKp3h1cxCL1qnFCgb+OmMljBByQ9uGG2E4Cf5eopnJkHU24G2GWXk3QTeoLLNzVwA4Frl WjJHzCPTILWzgvGb/ZA2iEuG4mZFI2QZwWQNOIv/WT4FUKmvsu8oTLxRVLfxC4Mx/k3S4RseDs1yo C8Y3GVQlaHe818nHBnIdW021cefuYbuWfIXKhprFK2rzIW2TR6IVB2W9uGoZs93Rx9si6cfy4OSLN A7HffXipNvMdJbtccxSA1uMGdmCAbvPnQORy2mOM8y77xROqGywyoqswsb4uYbzJEbja9DTKietQd 5I1QMHkFA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:58158) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kBc20-0005uF-Hw; Fri, 28 Aug 2020 11:54:52 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1kBc1u-00034A-V9; Fri, 28 Aug 2020 11:54:46 +0100 Date: Fri, 28 Aug 2020 11:54:46 +0100 From: Russell King - ARM Linux admin To: Landen Chao Cc: Sean Wang , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S . Miller" , Jakub Kicinski , Matthias Brugger , dqfext@gmail.com, frank-w@public-files.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, opensource@vdorst.com, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net v2] net: dsa: mt7530: fix advertising unsupported 1000baseT_Half Message-ID: <20200828105446.GK1551@shell.armlinux.org.uk> References: <20200828105244.9839-1-landen.chao@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200828105244.9839-1-landen.chao@mediatek.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Aug 28, 2020 at 06:52:44PM +0800, Landen Chao wrote: > Remove 1000baseT_Half to advertise correct hardware capability in > phylink_validate() callback function. > > Fixes: 38f790a80560 ("net: dsa: mt7530: Add support for port 5") > Signed-off-by: Landen Chao > Reviewed-by: Andrew Lunn > Reviewed-by: Florian Fainelli Reviewed-by: Russell King Thanks. > --- > v1->v2 > - fix the commit subject spilled into the commit message > --- > drivers/net/dsa/mt7530.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c > index 8dcb8a49ab67..238417db26f9 100644 > --- a/drivers/net/dsa/mt7530.c > +++ b/drivers/net/dsa/mt7530.c > @@ -1501,7 +1501,7 @@ static void mt7530_phylink_validate(struct dsa_switch *ds, int port, > phylink_set(mask, 100baseT_Full); > > if (state->interface != PHY_INTERFACE_MODE_MII) { > - phylink_set(mask, 1000baseT_Half); > + /* This switch only supports 1G full-duplex. */ > phylink_set(mask, 1000baseT_Full); > if (port == 5) > phylink_set(mask, 1000baseX_Full); > -- > 2.17.1 > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!