From: Andrew Lunn <andrew@lunn.ch>
To: "Adam Rudziński" <adam.rudzinski@arf.net.pl>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
netdev <netdev@vger.kernel.org>,
robh+dt@kernel.org, frowand.list@gmail.com
Subject: Re: drivers/of/of_mdio.c needs a small modification
Date: Sun, 30 Aug 2020 01:16:32 +0200 [thread overview]
Message-ID: <20200829231632.GB2966560@lunn.ch> (raw)
In-Reply-To: <79bcab16-5802-c075-1615-06c64078b6c9@arf.net.pl>
> I meant that with the split description of the mdio node the mdio bus for
> use in the system would be selected almost automatically. Suppose that I can
> do the device tree "my way":
> &fec2 {
> ...
> mdio { phy2 ... };
> ...
> };
> &fec1 {
> ...
> mdio { phy1 ... };
> ...
> };
> This emphasizes which PHY is intended for use by which FEC, that's why it
> looks more natural for me.
And it looks really wrong to me. It suggests there are two busses, and
each PHY is on its own bus. When in fact there is one MDIO bus with
two PHYs. Device tree should represents the real hardware, not some
pseudo description.
Andrew
next prev parent reply other threads:[~2020-08-29 23:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <c8b74845-b9e1-6d85-3947-56333b73d756@arf.net.pl>
2020-08-28 22:28 ` drivers/of/of_mdio.c needs a small modification Andrew Lunn
2020-08-28 22:34 ` Adam Rudziński
2020-08-28 22:53 ` Andrew Lunn
2020-08-28 23:14 ` Adam Rudziński
2020-08-29 3:29 ` Florian Fainelli
2020-08-29 8:15 ` Adam Rudziński
2020-08-29 15:15 ` Andrew Lunn
2020-08-29 15:37 ` Adam Rudziński
2020-08-29 16:00 ` Andrew Lunn
2020-08-29 18:01 ` Adam Rudziński
2020-08-29 23:16 ` Andrew Lunn [this message]
2020-08-30 20:47 ` Adam Rudziński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200829231632.GB2966560@lunn.ch \
--to=andrew@lunn.ch \
--cc=adam.rudzinski@arf.net.pl \
--cc=f.fainelli@gmail.com \
--cc=frowand.list@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).