From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 978DEC433E2 for ; Tue, 1 Sep 2020 20:12:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 722C12078B for ; Tue, 1 Sep 2020 20:12:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728865AbgIAUMc (ORCPT ); Tue, 1 Sep 2020 16:12:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726764AbgIAUMc (ORCPT ); Tue, 1 Sep 2020 16:12:32 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20AA2C061244 for ; Tue, 1 Sep 2020 13:12:32 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 3DE0E1364C885; Tue, 1 Sep 2020 12:55:45 -0700 (PDT) Date: Tue, 01 Sep 2020 13:12:31 -0700 (PDT) Message-Id: <20200901.131231.1278149582483928992.davem@davemloft.net> To: echaudro@redhat.com Cc: netdev@vger.kernel.org, dev@openvswitch.org, kuba@kernel.org, pabeni@redhat.com, pshelar@ovn.org Subject: Re: [PATCH net-next] net: openvswitch: fixes crash if nf_conncount_init() fails From: David Miller In-Reply-To: <159886787741.29248.5272329110875821435.stgit@ebuild> References: <159886787741.29248.5272329110875821435.stgit@ebuild> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [2620:137:e000::1:9]); Tue, 01 Sep 2020 12:55:45 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Eelco Chaudron Date: Mon, 31 Aug 2020 11:57:57 +0200 > If nf_conncount_init fails currently the dispatched work is not canceled, > causing problems when the timer fires. This change fixes this by not > scheduling the work until all initialization is successful. > > Fixes: a65878d6f00b ("net: openvswitch: fixes potential deadlock in dp cleanup code") > Reported-by: kernel test robot > Signed-off-by: Eelco Chaudron Applied, thank you.