From: Jesper Dangaard Brouer <brouer@redhat.com>
To: "Björn Töpel" <bjorn.topel@gmail.com>
Cc: ast@kernel.org, daniel@iogearbox.net, bpf@vger.kernel.org,
"Björn Töpel" <bjorn.topel@intel.com>,
magnus.karlsson@intel.com, netdev@vger.kernel.org,
toke@redhat.com, dsahern@gmail.com, brouer@redhat.com
Subject: Re: [PATCH bpf-next v2] bpf: {cpu,dev}map: change various functions return type from int to void
Date: Tue, 1 Sep 2020 11:16:08 +0200 [thread overview]
Message-ID: <20200901111608.5f56264d@carbon> (raw)
In-Reply-To: <20200901083928.6199-1-bjorn.topel@gmail.com>
On Tue, 1 Sep 2020 10:39:28 +0200
Björn Töpel <bjorn.topel@gmail.com> wrote:
> From: Björn Töpel <bjorn.topel@intel.com>
>
> The functions bq_enqueue(), bq_flush_to_queue(), and bq_xmit_all() in
> {cpu,dev}map.c always return zero. Changing the return type from int
> to void makes the code easier to follow.
>
> Suggested-by: David Ahern <dsahern@gmail.com>
> Signed-off-by: Björn Töpel <bjorn.topel@intel.com>
> ---
> kernel/bpf/cpumap.c | 11 +++--------
> kernel/bpf/devmap.c | 15 +++++++--------
> 2 files changed, 10 insertions(+), 16 deletions(-)
Thanks for the cleanup! :-)
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2020-09-01 9:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 8:39 [PATCH bpf-next v2] bpf: {cpu,dev}map: change various functions return type from int to void Björn Töpel
2020-09-01 9:16 ` Jesper Dangaard Brouer [this message]
2020-09-01 9:30 ` Toke Høiland-Jørgensen
2020-09-01 14:21 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200901111608.5f56264d@carbon \
--to=brouer@redhat.com \
--cc=ast@kernel.org \
--cc=bjorn.topel@gmail.com \
--cc=bjorn.topel@intel.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=dsahern@gmail.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).