From: "Gustavo A. R. Silva" <gustavoars@kernel.org>
To: Leesoo Ahn <dev@ooseel.net>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Lukas Wunner <lukas@wunner.de>,
Alexey Dobriyan <adobriyan@gmail.com>,
Niu Xilei <niu_xilei@163.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pktgen: fix error message with wrong function name
Date: Tue, 1 Sep 2020 12:25:56 -0500 [thread overview]
Message-ID: <20200901172556.GA31464@embeddedor> (raw)
In-Reply-To: <20200901130449.15422-1-dev@ooseel.net>
On Tue, Sep 01, 2020 at 10:04:47PM +0900, Leesoo Ahn wrote:
> Error on calling kthread_create_on_node prints wrong function name,
> kernel_thread.
>
> Signed-off-by: Leesoo Ahn <dev@ooseel.net>
You might need to add the following tag:
Fixes: 94dcf29a11b3 ("kthread: use kthread_create_on_node()")
Acked-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Thanks
--
Gustavo
> ---
> net/core/pktgen.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/core/pktgen.c b/net/core/pktgen.c
> index 95f4c6b8f51a..44fdbb9c6e53 100644
> --- a/net/core/pktgen.c
> +++ b/net/core/pktgen.c
> @@ -3699,7 +3699,7 @@ static int __net_init pktgen_create_thread(int cpu, struct pktgen_net *pn)
> cpu_to_node(cpu),
> "kpktgend_%d", cpu);
> if (IS_ERR(p)) {
> - pr_err("kernel_thread() failed for cpu %d\n", t->cpu);
> + pr_err("kthread_create_on_node() failed for cpu %d\n", t->cpu);
> list_del(&t->th_list);
> kfree(t);
> return PTR_ERR(p);
> --
> 2.25.4
>
next prev parent reply other threads:[~2020-09-01 17:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 13:04 [PATCH] pktgen: fix error message with wrong function name Leesoo Ahn
2020-09-01 17:25 ` Gustavo A. R. Silva [this message]
2020-09-01 18:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200901172556.GA31464@embeddedor \
--to=gustavoars@kernel.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=dev@ooseel.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mchehab+huawei@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niu_xilei@163.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).