From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53B52C433E7 for ; Tue, 1 Sep 2020 21:48:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 26587207EA for ; Tue, 1 Sep 2020 21:48:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729104AbgIAVs5 (ORCPT ); Tue, 1 Sep 2020 17:48:57 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:36850 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727778AbgIAVs5 (ORCPT ); Tue, 1 Sep 2020 17:48:57 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kDE96-00ConX-Ur; Tue, 01 Sep 2020 23:48:52 +0200 Date: Tue, 1 Sep 2020 23:48:52 +0200 From: Andrew Lunn To: Alex Elder Cc: Jakub Kicinski , Networking Subject: Re: COMPILE_TEST Message-ID: <20200901214852.GA3050651@lunn.ch> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Sep 01, 2020 at 03:22:31PM -0500, Alex Elder wrote: > Jakub, you suggested/requested that the Qualcomm IPA driver get > built when the COMPILE_TEST config option is enabled. I started > working on this a few months ago but didn't finish, and picked > it up again today. I'd really like to get this done soon. > > The QCOM_IPA config option depends on and selects other things, > and those other things depend on and select still more config > options. I've worked through some of these, but now question > whether this is even the right approach. Should I try to ensure > all the code the IPA driver depends on and selects *also* gets > built when COMPILE_TEST is enabled? Or should I try to minimize > the impact on other code by making IPA config dependencies and > selections also depend on the value of COMPILE_TEST? > > Is there anything you know of that describes best practice for > enabling a config option when COMPILE_TEST is enabled? Hi Alex In general everything which can be build with COMPILE_TEST should be built with COMPILE_TEST. So generally it just works, because everything selected should already be selected because they already have COMPILE_TEST. Correctly written drivers should compile for just about any architecture. If they don't it suggests they are not using the APIs correctly, and should be fixed. If the dependencies have not had COMPILE_TEST before, you are probably in for some work, but in the end all the drivers will be of better quality, and get build tested a lot more. Andrew