From: Andrew Lunn <andrew@lunn.ch>
To: David Awogbemila <awogbemila@google.com>
Cc: netdev@vger.kernel.org, Catherine Sullivan <csully@google.com>,
Yangchun Fu <yangchun@google.com>
Subject: Re: [PATCH net-next v2 3/9] gve: Use dev_info/err instead of netif_info/err.
Date: Wed, 2 Sep 2020 00:08:14 +0200 [thread overview]
Message-ID: <20200901220814.GD3050651@lunn.ch> (raw)
In-Reply-To: <20200901215149.2685117-4-awogbemila@google.com>
> @@ -1133,7 +1133,9 @@ static int gve_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
> goto abort_with_db_bar;
> }
> SET_NETDEV_DEV(dev, &pdev->dev);
> +
> pci_set_drvdata(pdev, dev);
> +
> dev->ethtool_ops = &gve_ethtool_ops;
> dev->netdev_ops = &gve_netdev_ops;
> /* advertise features */
> @@ -1160,6 +1162,7 @@ static int gve_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
> priv->state_flags = 0x0;
>
> gve_set_probe_in_progress(priv);
> +
> priv->gve_wq = alloc_ordered_workqueue("gve", 0);
> if (!priv->gve_wq) {
> dev_err(&pdev->dev, "Could not allocate workqueue");
> @@ -1181,6 +1184,7 @@ static int gve_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
> dev_info(&pdev->dev, "GVE version %s\n", gve_version_str);
> gve_clear_probe_in_progress(priv);
> queue_work(priv->gve_wq, &priv->service_task);
> +
> return 0;
>
> abort_with_wq:
No white space changes please. If you want these, put them into a
patch of there own.
Andrew
next prev parent reply other threads:[~2020-09-01 22:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 21:51 [PATCH net-next v2 0/9] Add GVE Features David Awogbemila
2020-09-01 21:51 ` [PATCH net-next v2 1/9] gve: Get and set Rx copybreak via ethtool David Awogbemila
2020-09-01 22:06 ` Andrew Lunn
2020-09-01 21:51 ` [PATCH net-next v2 2/9] gve: Add stats for gve David Awogbemila
2020-09-02 0:28 ` Jakub Kicinski
2020-09-01 21:51 ` [PATCH net-next v2 3/9] gve: Use dev_info/err instead of netif_info/err David Awogbemila
2020-09-01 22:08 ` Andrew Lunn [this message]
2020-09-02 18:43 ` David Awogbemila
2020-09-01 21:51 ` [PATCH net-next v2 4/9] gve: Add support for dma_mask register David Awogbemila
2020-09-02 0:34 ` Jakub Kicinski
2020-09-02 18:42 ` David Awogbemila
2020-09-02 23:08 ` David Miller
2020-09-03 16:31 ` David Awogbemila
2020-09-03 18:28 ` Jakub Kicinski
2020-09-01 21:51 ` [PATCH net-next v2 5/9] gve: Add Gvnic stats AQ command and ethtool show/set-priv-flags David Awogbemila
2020-09-02 0:45 ` Jakub Kicinski
2020-09-02 20:39 ` David Awogbemila
2020-09-03 0:05 ` David Awogbemila
2020-09-01 21:51 ` [PATCH net-next v2 6/9] gve: NIC stats for report-stats and for ethtool David Awogbemila
2020-09-01 21:51 ` [PATCH net-next v2 7/9] gve: Batch AQ commands for creating and destroying queues David Awogbemila
2020-09-01 21:51 ` [PATCH net-next v2 8/9] gve: Use link status register to report link status David Awogbemila
2020-09-01 21:51 ` [PATCH net-next v2 9/9] gve: Enable Link Speed Reporting in the driver David Awogbemila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200901220814.GD3050651@lunn.ch \
--to=andrew@lunn.ch \
--cc=awogbemila@google.com \
--cc=csully@google.com \
--cc=netdev@vger.kernel.org \
--cc=yangchun@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).