From: Jiri Pirko <jiri@resnulli.us>
To: Sunil Kovvuri Goutham <sgoutham@marvell.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
"sundeep.lkml@gmail.com" <sundeep.lkml@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Subbaraya Sundeep Bhatta <sbhatta@marvell.com>
Subject: Re: [EXT] Re: [net-next PATCH 0/2] Introduce mbox tracepoints for Octeontx2
Date: Fri, 4 Sep 2020 14:11:26 +0200 [thread overview]
Message-ID: <20200904121126.GI2997@nanopsycho.orion> (raw)
In-Reply-To: <BY5PR18MB3298EB53D2F869D64D7F534DC62D0@BY5PR18MB3298.namprd18.prod.outlook.com>
Fri, Sep 04, 2020 at 10:49:45AM CEST, sgoutham@marvell.com wrote:
>
>
>> -----Original Message-----
>> From: Jiri Pirko <jiri@resnulli.us>
>> Sent: Friday, September 4, 2020 2:07 PM
>> To: Sunil Kovvuri Goutham <sgoutham@marvell.com>
>> Cc: Jakub Kicinski <kuba@kernel.org>; sundeep.lkml@gmail.com;
>> davem@davemloft.net; netdev@vger.kernel.org; Subbaraya Sundeep
>> Bhatta <sbhatta@marvell.com>
>> Subject: Re: [EXT] Re: [net-next PATCH 0/2] Introduce mbox tracepoints for
>> Octeontx2
>>
>> Fri, Sep 04, 2020 at 07:39:54AM CEST, sgoutham@marvell.com wrote:
>> >
>> >
>> >> -----Original Message-----
>> >> From: Jakub Kicinski <kuba@kernel.org>
>> >> Sent: Friday, September 4, 2020 12:48 AM
>> >> To: sundeep.lkml@gmail.com
>> >> Cc: davem@davemloft.net; netdev@vger.kernel.org; Sunil Kovvuri
>> >> Goutham <sgoutham@marvell.com>; Subbaraya Sundeep Bhatta
>> >> <sbhatta@marvell.com>
>> >> Subject: [EXT] Re: [net-next PATCH 0/2] Introduce mbox tracepoints
>> >> for
>> >> Octeontx2
>> >>
>> >> External Email
>> >>
>> >> ---------------------------------------------------------------------
>> >> - On Thu, 3 Sep 2020 12:48:16 +0530 sundeep.lkml@gmail.com wrote:
>> >> > From: Subbaraya Sundeep <sbhatta@marvell.com>
>> >> >
>> >> > This patchset adds tracepoints support for mailbox.
>> >> > In Octeontx2, PFs and VFs need to communicate with AF for
>> >> > allocating and freeing resources. Once all the configuration is
>> >> > done by AF for a PF/VF then packet I/O can happen on PF/VF queues.
>> >> > When an interface is brought up many mailbox messages are sent to
>> >> > AF for initializing queues. Say a VF is brought up then each
>> >> > message is sent to PF and PF forwards to AF and response also traverses
>> from AF to PF and then VF.
>> >> > To aid debugging, tracepoints are added at places where messages
>> >> > are allocated, sent and message interrupts.
>> >> > Below is the trace of one of the messages from VF to AF and AF
>> >> > response back to VF:
>> >>
>> >> Could you use the devlink tracepoint? trace_devlink_hwmsg() ?
>> >
>> >Thanks for the suggestion.
>> >In our case the mailbox is central to 3 different drivers and there
>> >would be a 4th one once crypto driver is accepted. We cannot add
>> >devlink to all of them inorder to use the devlink trace points.
>>
>> I guess you have 1 pci device, right? Devlink instance is created per pci
>> device.
>>
>
>No, there are 3 drivers registering to 3 PCI device IDs and there can be many
>instances of the same devices. So there can be 10's of instances of AF, PF and VFs.
So you can still have per-pci device devlink instance and use the
tracepoint Jakub suggested.
>
>Thanks,
>Sunil.
next prev parent reply other threads:[~2020-09-04 12:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 7:18 [net-next PATCH 0/2] Introduce mbox tracepoints for Octeontx2 sundeep.lkml
2020-09-03 7:18 ` [net-next PATCH 1/2] octeontx2-af: Introduce tracepoints for mailbox sundeep.lkml
2020-09-03 7:18 ` [net-next PATCH 2/2] octeontx2-pf: Add tracepoints for PF/VF mailbox sundeep.lkml
2020-09-03 19:18 ` [net-next PATCH 0/2] Introduce mbox tracepoints for Octeontx2 Jakub Kicinski
2020-09-04 5:39 ` [EXT] " Sunil Kovvuri Goutham
2020-09-04 8:37 ` Jiri Pirko
2020-09-04 8:49 ` Sunil Kovvuri Goutham
2020-09-04 12:11 ` Jiri Pirko [this message]
2020-09-04 12:29 ` Sunil Kovvuri Goutham
2020-09-04 20:37 ` Jakub Kicinski
2020-09-07 10:59 ` sundeep subbaraya
2020-09-15 15:52 ` sundeep subbaraya
2020-09-15 16:12 ` Jakub Kicinski
2020-09-15 16:36 ` sundeep subbaraya
2020-09-15 16:44 ` Jakub Kicinski
2020-09-16 10:34 ` Jiri Pirko
2020-09-16 17:19 ` sundeep subbaraya
2020-09-17 6:04 ` Jiri Pirko
2020-09-17 10:30 ` sundeep subbaraya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200904121126.GI2997@nanopsycho.orion \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=sundeep.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).