netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steffen Klassert <steffen.klassert@secunet.com>
To: Dmitry Safonov <dima@arista.com>
Cc: <linux-kernel@vger.kernel.org>,
	Dmitry Safonov <0x7f454c46@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Florian Westphal <fw@strlen.de>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Jakub Kicinski <kuba@kernel.org>,
	Stephen Suryaputra <ssuryaextr@gmail.com>,
	<netdev@vger.kernel.org>
Subject: Re: [PATCH v2 1/6] xfrm/compat: Add 64=>32-bit messages translator
Date: Mon, 7 Sep 2020 13:24:11 +0200	[thread overview]
Message-ID: <20200907112411.GK20687@gauss3.secunet.de> (raw)
In-Reply-To: <20200826014949.644441-2-dima@arista.com>

On Wed, Aug 26, 2020 at 02:49:44AM +0100, Dmitry Safonov wrote:
> XFRM is disabled for compatible users because of the UABI difference.
> The difference is in structures paddings and in the result the size
> of netlink messages differ.
> 
> Possibility for compatible application to manage xfrm tunnels was
> disabled by: the commmit 19d7df69fdb2 ("xfrm: Refuse to insert 32 bit
> userspace socket policies on 64 bit systems") and the commit 74005991b78a
> ("xfrm: Do not parse 32bits compiled xfrm netlink msg on 64bits host").
> 
> This is my second attempt to resolve the xfrm/compat problem by adding
> the 64=>32 and 32=>64 bit translators those non-visibly to a user
> provide translation between compatible user and kernel.
> Previous attempt was to interrupt the message ABI according to a syscall
> by xfrm_user, which resulted in over-complicated code [1].
> 
> Florian Westphal provided the idea of translator and some draft patches
> in the discussion. In these patches, his idea is reused and some of his
> initial code is also present.

One comment on this. Looks like the above is the same in all
commit messages. Please provide that generic information
with the patch 0/n and remove it from the other patches.



  parent reply	other threads:[~2020-09-07 11:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-26  1:49 [PATCH v2 0/6] xfrm: Add compat layer Dmitry Safonov
2020-08-26  1:49 ` [PATCH v2 1/6] xfrm/compat: Add 64=>32-bit messages translator Dmitry Safonov
2020-08-26  4:03   ` kernel test robot
2020-09-07 11:24   ` Steffen Klassert [this message]
2020-09-07 17:01     ` Dmitry Safonov
2020-08-26  1:49 ` [PATCH v2 2/6] xfrm/compat: Attach xfrm dumps to 64=>32 bit translator Dmitry Safonov
2020-08-26  1:49 ` [PATCH v2 3/6] netlink/compat: Append NLMSG_DONE/extack to frag_list Dmitry Safonov
2020-08-26  7:19   ` Johannes Berg
2020-09-07 16:41     ` Dmitry Safonov
2020-08-26  1:49 ` [PATCH v2 4/6] xfrm/compat: Add 32=>64-bit messages translator Dmitry Safonov
2020-08-26  1:49 ` [PATCH v2 5/6] xfrm/compat: Translate 32-bit user_policy from sockptr Dmitry Safonov
2020-08-26  1:49 ` [PATCH v2 6/6] selftest/net/xfrm: Add test for ipsec tunnel Dmitry Safonov
2020-09-07  9:43 ` [PATCH v2 0/6] xfrm: Add compat layer Steffen Klassert
2020-09-07 16:51   ` Dmitry Safonov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200907112411.GK20687@gauss3.secunet.de \
    --to=steffen.klassert@secunet.com \
    --cc=0x7f454c46@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dima@arista.com \
    --cc=fw@strlen.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=ssuryaextr@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).