From: David Miller <davem@davemloft.net>
To: saeedm@nvidia.com
Cc: kuba@kernel.org, netdev@vger.kernel.org, maximmi@mellanox.com,
tariqt@mellanox.com
Subject: Re: [net-next V2 03/12] net/mlx5e: Move mlx5e_tx_wqe_inline_mode to en_tx.c
Date: Tue, 08 Sep 2020 20:29:13 -0700 (PDT) [thread overview]
Message-ID: <20200908.202913.497073980249985510.davem@davemloft.net> (raw)
In-Reply-To: <20200908.202836.574556740303703917.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Tue, 08 Sep 2020 20:28:36 -0700 (PDT)
> From: Saeed Mahameed <saeedm@nvidia.com>
> Date: Tue, 8 Sep 2020 18:27:48 -0700
>
>> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c
>> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c
>> @@ -232,6 +232,29 @@ mlx5e_txwqe_build_dsegs(struct mlx5e_txqsq *sq, struct sk_buff *skb,
>> return -ENOMEM;
>> }
>>
>> +static inline bool mlx5e_transport_inline_tx_wqe(struct mlx5_wqe_ctrl_seg *cseg)
>> +{
>> + return cseg && !!cseg->tis_tir_num;
>> +}
>> +
>> +static inline u8
>> +mlx5e_tx_wqe_inline_mode(struct mlx5e_txqsq *sq, struct mlx5_wqe_ctrl_seg *cseg,
>> + struct sk_buff *skb)
>> +{
>
> No inlines in foo.c files, please.
I see you're doing this even more later in this series.
Please fix all of this up, thank you.
next prev parent reply other threads:[~2020-09-09 3:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 1:27 [pull request][net-next V2 00/12] mlx5 Multi packet tx descriptors for SKBs Saeed Mahameed
2020-09-09 1:27 ` [net-next V2 01/12] net/mlx5e: Refactor inline header size calculation in the TX path Saeed Mahameed
2020-09-09 1:27 ` [net-next V2 02/12] net/mlx5e: Use struct assignment to initialize mlx5e_tx_wqe_info Saeed Mahameed
2020-09-09 1:27 ` [net-next V2 03/12] net/mlx5e: Move mlx5e_tx_wqe_inline_mode to en_tx.c Saeed Mahameed
2020-09-09 3:28 ` David Miller
2020-09-09 3:29 ` David Miller [this message]
2020-09-09 19:22 ` Saeed Mahameed
2020-09-09 19:28 ` Jakub Kicinski
2020-09-09 20:48 ` Saeed Mahameed
2020-09-09 21:34 ` David Miller
2020-09-11 17:25 ` Saeed Mahameed
2020-09-09 1:27 ` [net-next V2 04/12] net/mlx5e: Refactor xmit functions Saeed Mahameed
2020-09-09 1:27 ` [net-next V2 05/12] net/mlx5e: Small improvements for XDP TX MPWQE logic Saeed Mahameed
2020-09-09 1:27 ` [net-next V2 06/12] net/mlx5e: Unify constants for WQE_EMPTY_DS_COUNT Saeed Mahameed
2020-09-09 1:27 ` [net-next V2 07/12] net/mlx5e: Move the TLS resync check out of the function Saeed Mahameed
2020-09-09 1:27 ` [net-next V2 08/12] net/mlx5e: Support multiple SKBs in a TX WQE Saeed Mahameed
2020-09-09 1:27 ` [net-next V2 09/12] net/mlx5e: Generalize TX MPWQE checks for full session Saeed Mahameed
2020-09-09 1:27 ` [net-next V2 10/12] net/mlx5e: Rename xmit-related structs to generalize them Saeed Mahameed
2020-09-09 1:27 ` [net-next V2 11/12] net/mlx5e: Move TX code into functions to be used by MPWQE Saeed Mahameed
2020-09-09 1:27 ` [net-next V2 12/12] net/mlx5e: Enhanced TX MPWQE for SKBs Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200908.202913.497073980249985510.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=maximmi@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).