From: Andrew Lunn <andrew@lunn.ch>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: kuba@kernel.org, f.fainelli@gmail.com, vivien.didelot@gmail.com,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: dsa: don't print non-fatal MTU error if not supported
Date: Tue, 8 Sep 2020 02:57:09 +0200 [thread overview]
Message-ID: <20200908005709.GB3267902@lunn.ch> (raw)
In-Reply-To: <20200907232556.1671828-1-olteanv@gmail.com>
On Tue, Sep 08, 2020 at 02:25:56AM +0300, Vladimir Oltean wrote:
> Commit 72579e14a1d3 ("net: dsa: don't fail to probe if we couldn't set
> the MTU") changed, for some reason, the "err && err != -EOPNOTSUPP"
> check into a simple "err". This causes the MTU warning to be printed
> even for drivers that don't have the MTU operations implemented.
> Fix that.
Hi Vladimir
In some ways, this has been good. A lot more DSA drivers now have MTU
support and jumbo packet support.
> Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2020-09-08 0:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 23:25 [PATCH net-next] net: dsa: don't print non-fatal MTU error if not supported Vladimir Oltean
2020-09-08 0:57 ` Andrew Lunn [this message]
2020-09-08 1:08 ` Vladimir Oltean
2020-09-08 3:06 ` Florian Fainelli
2020-09-08 4:01 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200908005709.GB3267902@lunn.ch \
--to=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox