* [PATCH] net: tracepoint: fix print wrong sysctl_mem value
@ 2020-09-07 14:47 Dust Li
2020-09-07 17:50 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Dust Li @ 2020-09-07 14:47 UTC (permalink / raw)
To: David S . Miller, Eric Dumazet, Satoru Moriya; +Cc: netdev
sysctl_mem is an point, and tracepoint entry do not support
been visited like an array. Use 3 long type to get sysctl_mem
instead.
tracpoint output with and without this fix:
- without fix:
28821.074 sock:sock_exceed_buf_limit:proto:UDP
sysctl_mem=-1741233440,19,322156906942464 allocated=19 sysctl_rmem=4096
rmem_alloc=75008 sysctl_wmem=4096 wmem_alloc=1 wmem_queued=0
kind=SK_MEM_RECV
- with fix:
2126.136 sock:sock_exceed_buf_limit:proto:UDP
sysctl_mem=18,122845,184266 allocated=19 sysctl_rmem=4096
rmem_alloc=73728 sysctl_wmem=4096 wmem_alloc=1 wmem_queued=0
kind=SK_MEM_RECV
Fixes: 3847ce32aea9fdf ("core: add tracepoints for queueing skb to rcvbuf")
Signed-off-by: Dust Li <dust.li@linux.alibaba.com>
---
include/trace/events/sock.h | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/include/trace/events/sock.h b/include/trace/events/sock.h
index a966d4b5ab37..9118dd2353b7 100644
--- a/include/trace/events/sock.h
+++ b/include/trace/events/sock.h
@@ -98,7 +98,9 @@ TRACE_EVENT(sock_exceed_buf_limit,
TP_STRUCT__entry(
__array(char, name, 32)
- __field(long *, sysctl_mem)
+ __field(long, sysctl_mem0)
+ __field(long, sysctl_mem1)
+ __field(long, sysctl_mem2)
__field(long, allocated)
__field(int, sysctl_rmem)
__field(int, rmem_alloc)
@@ -110,7 +112,9 @@ TRACE_EVENT(sock_exceed_buf_limit,
TP_fast_assign(
strncpy(__entry->name, prot->name, 32);
- __entry->sysctl_mem = prot->sysctl_mem;
+ __entry->sysctl_mem0 = prot->sysctl_mem[0];
+ __entry->sysctl_mem1 = prot->sysctl_mem[1];
+ __entry->sysctl_mem2 = prot->sysctl_mem[2];
__entry->allocated = allocated;
__entry->sysctl_rmem = sk_get_rmem0(sk, prot);
__entry->rmem_alloc = atomic_read(&sk->sk_rmem_alloc);
@@ -122,9 +126,9 @@ TRACE_EVENT(sock_exceed_buf_limit,
TP_printk("proto:%s sysctl_mem=%ld,%ld,%ld allocated=%ld sysctl_rmem=%d rmem_alloc=%d sysctl_wmem=%d wmem_alloc=%d wmem_queued=%d kind=%s",
__entry->name,
- __entry->sysctl_mem[0],
- __entry->sysctl_mem[1],
- __entry->sysctl_mem[2],
+ __entry->sysctl_mem0,
+ __entry->sysctl_mem1,
+ __entry->sysctl_mem2,
__entry->allocated,
__entry->sysctl_rmem,
__entry->rmem_alloc,
--
2.19.1.3.ge56e4f7
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net: tracepoint: fix print wrong sysctl_mem value
2020-09-07 14:47 [PATCH] net: tracepoint: fix print wrong sysctl_mem value Dust Li
@ 2020-09-07 17:50 ` Jakub Kicinski
2020-09-08 1:50 ` dust.li
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2020-09-07 17:50 UTC (permalink / raw)
To: Dust Li; +Cc: David S . Miller, Eric Dumazet, Satoru Moriya, netdev
On Mon, 7 Sep 2020 22:47:57 +0800 Dust Li wrote:
> sysctl_mem is an point, and tracepoint entry do not support
> been visited like an array. Use 3 long type to get sysctl_mem
> instead.
>
> tracpoint output with and without this fix:
> - without fix:
> 28821.074 sock:sock_exceed_buf_limit:proto:UDP
> sysctl_mem=-1741233440,19,322156906942464 allocated=19 sysctl_rmem=4096
> rmem_alloc=75008 sysctl_wmem=4096 wmem_alloc=1 wmem_queued=0
> kind=SK_MEM_RECV
>
> - with fix:
> 2126.136 sock:sock_exceed_buf_limit:proto:UDP
> sysctl_mem=18,122845,184266 allocated=19 sysctl_rmem=4096
> rmem_alloc=73728 sysctl_wmem=4096 wmem_alloc=1 wmem_queued=0
> kind=SK_MEM_RECV
>
> Fixes: 3847ce32aea9fdf ("core: add tracepoints for queueing skb to rcvbuf")
> Signed-off-by: Dust Li <dust.li@linux.alibaba.com>
> ---
> include/trace/events/sock.h | 14 +++++++++-----
> 1 file changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/include/trace/events/sock.h b/include/trace/events/sock.h
> index a966d4b5ab37..9118dd2353b7 100644
> --- a/include/trace/events/sock.h
> +++ b/include/trace/events/sock.h
> @@ -98,7 +98,9 @@ TRACE_EVENT(sock_exceed_buf_limit,
>
> TP_STRUCT__entry(
> __array(char, name, 32)
> - __field(long *, sysctl_mem)
> + __field(long, sysctl_mem0)
> + __field(long, sysctl_mem1)
> + __field(long, sysctl_mem2)
Why not make it an __array() ?
> __field(long, allocated)
> __field(int, sysctl_rmem)
> __field(int, rmem_alloc)
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net: tracepoint: fix print wrong sysctl_mem value
2020-09-07 17:50 ` Jakub Kicinski
@ 2020-09-08 1:50 ` dust.li
0 siblings, 0 replies; 3+ messages in thread
From: dust.li @ 2020-09-08 1:50 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: David S . Miller, Eric Dumazet, Satoru Moriya, netdev
On Mon, Sep 07, 2020 at 10:50:30AM -0700, Jakub Kicinski wrote:
>On Mon, 7 Sep 2020 22:47:57 +0800 Dust Li wrote:
>> sysctl_mem is an point, and tracepoint entry do not support
>> been visited like an array. Use 3 long type to get sysctl_mem
>> instead.
>>
>> tracpoint output with and without this fix:
>> - without fix:
>> 28821.074 sock:sock_exceed_buf_limit:proto:UDP
>> sysctl_mem=-1741233440,19,322156906942464 allocated=19 sysctl_rmem=4096
>> rmem_alloc=75008 sysctl_wmem=4096 wmem_alloc=1 wmem_queued=0
>> kind=SK_MEM_RECV
>>
>> - with fix:
>> 2126.136 sock:sock_exceed_buf_limit:proto:UDP
>> sysctl_mem=18,122845,184266 allocated=19 sysctl_rmem=4096
>> rmem_alloc=73728 sysctl_wmem=4096 wmem_alloc=1 wmem_queued=0
>> kind=SK_MEM_RECV
>>
>> Fixes: 3847ce32aea9fdf ("core: add tracepoints for queueing skb to rcvbuf")
>> Signed-off-by: Dust Li <dust.li@linux.alibaba.com>
>> ---
>> include/trace/events/sock.h | 14 +++++++++-----
>> 1 file changed, 9 insertions(+), 5 deletions(-)
>>
>> diff --git a/include/trace/events/sock.h b/include/trace/events/sock.h
>> index a966d4b5ab37..9118dd2353b7 100644
>> --- a/include/trace/events/sock.h
>> +++ b/include/trace/events/sock.h
>> @@ -98,7 +98,9 @@ TRACE_EVENT(sock_exceed_buf_limit,
>>
>> TP_STRUCT__entry(
>> __array(char, name, 32)
>> - __field(long *, sysctl_mem)
>> + __field(long, sysctl_mem0)
>> + __field(long, sysctl_mem1)
>> + __field(long, sysctl_mem2)
>
>Why not make it an __array() ?
Yeah, it's better using an __array(), I will send a v2.
Thanks !
>
>> __field(long, allocated)
>> __field(int, sysctl_rmem)
>> __field(int, rmem_alloc)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-08 1:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-07 14:47 [PATCH] net: tracepoint: fix print wrong sysctl_mem value Dust Li
2020-09-07 17:50 ` Jakub Kicinski
2020-09-08 1:50 ` dust.li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).