From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E0A9C43461 for ; Tue, 8 Sep 2020 08:46:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E585F215A4 for ; Tue, 8 Sep 2020 08:46:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cr10Cch9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730079AbgIHIql (ORCPT ); Tue, 8 Sep 2020 04:46:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730159AbgIHIqf (ORCPT ); Tue, 8 Sep 2020 04:46:35 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 741EAC061756 for ; Tue, 8 Sep 2020 01:46:33 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id m6so18230989wrn.0 for ; Tue, 08 Sep 2020 01:46:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=zxSReaeKsWNMqXHUrN/wepLZJeaGHtV4Xq/Uiup0Lq0=; b=cr10Cch9Nj+ChkzYu7awIXU7u2p6g+HckAnw0AN03Ju+nc4hZTJtgmLXQnnssbVsA4 JyplKDgV9jP7cqGeWflqT3QoH1Q6HGTr3zOCTB6f6bPRW0+WDpUe4RsIN/aiwq/eFpEY MSNz+OBZiVwLOO/M8167ynnFuRcd049fa650TjugZQ7OsntRCb3mMm84Mcz0epk+5oNM 7X/q3mUJDh5Pw2OuVzr1rvLrvpWers2I61YhPiRIF43Lqqg3ebYawDwdSsR1mXvTMrzv WbTJRcAz6L+88F8cL/ZFpH3pYQE7Ykt66Z75OGXAUhEOLXM04t5OPaHzEuH+oHNlXEKW 5JJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=zxSReaeKsWNMqXHUrN/wepLZJeaGHtV4Xq/Uiup0Lq0=; b=A5BRcGUWj79aarW58Uq8pBP6/ct38/ec+bOAtHXggk3hjPBZ57zCvNvaMg/BmOIvG8 fFor4y0fe+cbtnnphTTxzMSWsDs+cqXOlanYashWF0beN4Mg741+as1TMBFuVjuj2SrG 4q7QU78uuDzfnaBBaDNKN5t8tNzw7LPxt/Y8yGLexbBQ1U7QgiVEptyBbFmyKnQ+vxCu PuNvKD9/cSmVyXzEnROhOmykZ/ZicMaYQCKUSroh/BH6Z5HHA4w/mY6uSEYCRBOxlxip 8QH87aVBY6QzR1xmpmfwACiBCUxPqCcUaGhFXMs99OH2h5cjl3rVbO8Tj4/jhLgulhFs 15ag== X-Gm-Message-State: AOAM531XbYi7hBp1J9rEXs3LJkAB81TTcFhK04+d+259owybhGHsmKsZ vN2pzZCCspPejGIonad0U8vHhw== X-Google-Smtp-Source: ABdhPJxZbaSYb25L3hU2Pkh9dQuXeFyxa4dIIIyjnSG68UCmKVekbt2t/B5nwBHgLaYIh1vOZBLLLg== X-Received: by 2002:a05:6000:11cd:: with SMTP id i13mr6416895wrx.140.1599554792285; Tue, 08 Sep 2020 01:46:32 -0700 (PDT) Received: from dell ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id 9sm11623485wmf.7.2020.09.08.01.46.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2020 01:46:31 -0700 (PDT) Date: Tue, 8 Sep 2020 09:46:29 +0100 From: Lee Jones To: Kalle Valo Cc: davem@davemloft.net, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 00/32] Set 2: Rid W=1 warnings in Wireless Message-ID: <20200908084629.GI4400@dell> References: <20200821071644.109970-1-lee.jones@linaro.org> <87o8mp6epv.fsf@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87o8mp6epv.fsf@codeaurora.org> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 01 Sep 2020, Kalle Valo wrote: > Lee Jones writes: > > > This set is part of a larger effort attempting to clean-up W=1 > > kernel builds, which are currently overwhelmingly riddled with > > niggly little warnings. > > > > There are quite a few W=1 warnings in the Wireless. My plan > > is to work through all of them over the next few weeks. > > Hopefully it won't be too long before drivers/net/wireless > > builds clean with W=1 enabled. > > BTW, now the patches are in random order and it's quite annoying to > review when there's no logic. Grouping them by the driver would be a lot > more pleasent for reviewers. My script makes a best effort attempt to group changes by file. It takes the first warning presented by the compiler then greps the output for all issues pertaining to that file. I then split the patch by issue (i.e. different patches for; kernel-doc, unused variables, bracketing etc). One issue you might be seeing is the potential for one fixed issue to cause another i.e. when one unused variable is removed which was the only user of another, leading to a subsequent fix of the newly unused variable. Other than that, I'm not sure why they would end up out of order. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog