netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Divya Koppera <Divya.Koppera@microchip.com>
Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
	kuba@kernel.org, marex@denx.de, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH v1 net-next] net: phy: mchp: Add support for LAN8814 QUAD PHY
Date: Wed, 9 Sep 2020 15:51:04 +0200	[thread overview]
Message-ID: <20200909135104.GG3290129@lunn.ch> (raw)
In-Reply-To: <20200909093419.32102-1-Divya.Koppera@microchip.com>

> @@ -1314,6 +1314,21 @@ static struct phy_driver ksphy_driver[] = {
>  	.get_stats	= kszphy_get_stats,
>  	.suspend	= genphy_suspend,
>  	.resume		= kszphy_resume,
> +}, {
> +	.phy_id		= PHY_ID_LAN8814,
> +	.phy_id_mask	= MICREL_PHY_ID_MASK,
> +	.name		= "Microchip INDY Gigabit Quad PHY",
> +	.driver_data	= &ksz9021_type,
> +	.probe		= kszphy_probe,
> +	.get_features	= ksz9031_get_features,

static int ksz9031_get_features(struct phy_device *phydev)
{
	int ret;

	ret = genphy_read_abilities(phydev);
	if (ret < 0)
		return ret;

	/* Silicon Errata Sheet (DS80000691D or DS80000692D):


Hi Divya

Do these erratas apply to this PHY as well?

   Andrew

  reply	other threads:[~2020-09-09 17:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-09  9:34 [PATCH v1 net-next] net: phy: mchp: Add support for LAN8814 QUAD PHY Divya Koppera
2020-09-09 13:51 ` Andrew Lunn [this message]
2020-09-11  6:10 ` [PATCH v2 " Divya Koppera
2020-09-11 12:32   ` Andrew Lunn
2020-09-11 13:18   ` [PATCH v3 " Divya Koppera
2020-09-12  0:42     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200909135104.GG3290129@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=Divya.Koppera@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=davem@davemloft.net \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=marex@denx.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).