From: Richard Cochran <richardcochran@gmail.com>
To: Russell King <rmk+kernel@armlinux.org.uk>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Antoine Tenart <antoine.tenart@bootlin.com>,
Matteo Croce <mcroce@redhat.com>,
Andre Przywara <andre.przywara@arm.com>,
Sven Auhagen <sven.auhagen@voleatech.de>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v3 7/7] net: mvpp2: ptp: add support for transmit timestamping
Date: Wed, 9 Sep 2020 11:00:47 -0700 [thread overview]
Message-ID: <20200909180047.GB24551@hoboy> (raw)
In-Reply-To: <E1kFlfN-0006di-Pu@rmk-PC.armlinux.org.uk>
On Tue, Sep 08, 2020 at 11:00:41PM +0100, Russell King wrote:
> +static bool mvpp2_tx_hw_tstamp(struct mvpp2_port *port,
> + struct mvpp2_tx_desc *tx_desc,
> + struct sk_buff *skb)
> +{
> + unsigned int mtype, type, i, offset;
> + struct mvpp2_hwtstamp_queue *queue;
> + struct ptp_header *hdr;
> + u64 ptpdesc;
> +
> + if (port->priv->hw_version == MVPP21 ||
> + port->tx_hwtstamp_type == HWTSTAMP_TX_OFF)
> + return false;
> +
> + type = ptp_classify_raw(skb);
> + if (!type)
> + return false;
> +
> + hdr = ptp_parse_header(skb, type);
> + if (!hdr)
> + return false;
At this point, the skb will be queued up to receive a transmit time
stamp, and so it should be marked with:
skb_shinfo(skb)->tx_flags |= SKBTX_IN_PROGRESS;
The rest of the patch looks reasonable.
Acked-by: Richard Cochran <richardcochran@gmail.com>
next prev parent reply other threads:[~2020-09-09 18:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 21:47 [PATCH net-next v3 0/6] Marvell PP2.2 PTP support Russell King - ARM Linux admin
2020-09-08 22:00 ` [PATCH net-next v3 1/7] net: mvpp2: restructure "link status" interrupt handling Russell King
2020-09-08 22:00 ` [PATCH net-next v3 2/7] net: mvpp2: rename mis-named "link status" interrupt Russell King
2020-09-08 22:00 ` [PATCH net-next v3 3/7] net: mvpp2: check first level interrupt status registers Russell King
2020-09-08 22:00 ` [PATCH net-next v3 4/7] net: mvpp2: ptp: add TAI support Russell King
2020-09-08 22:00 ` [PATCH net-next v3 5/7] net: mvpp2: ptp: add support for receive timestamping Russell King
2020-09-08 22:00 ` [PATCH net-next v3 6/7] net: mvpp2: ptp: add interrupt handling Russell King
2020-09-08 22:00 ` [PATCH net-next v3 7/7] net: mvpp2: ptp: add support for transmit timestamping Russell King
2020-09-08 23:40 ` Richard Cochran
2020-09-08 23:50 ` Russell King - ARM Linux admin
2020-09-09 18:00 ` Richard Cochran [this message]
2020-09-11 16:08 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200909180047.GB24551@hoboy \
--to=richardcochran@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andre.przywara@arm.com \
--cc=antoine.tenart@bootlin.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=mcroce@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=sven.auhagen@voleatech.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox