From: Moritz Fischer <mdf@kernel.org>
To: Lucy Yan <lucyyan@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Arnd Bergmann <arnd@arndb.de>, Moritz Fischer <mdf@kernel.org>,
Leon Romanovsky <leon@kernel.org>,
"Michael S . Tsirkin" <mst@redhat.com>,
Vaibhav Gupta <vaibhavgupta40@gmail.com>,
netdev@vger.kernel.org, linux-parisc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: dec: de2104x: Increase receive ring size for Tulip
Date: Thu, 10 Sep 2020 12:33:45 -0700 [thread overview]
Message-ID: <20200910193345.GA28525@archbook> (raw)
In-Reply-To: <20200910190509.81755-1-lucyyan@google.com>
On Thu, Sep 10, 2020 at 12:05:09PM -0700, Lucy Yan wrote:
> Increase Rx ring size to address issue where hardware is reaching
> the receive work limit.
>
> Before:
>
> [ 102.223342] de2104x 0000:17:00.0 eth0: rx work limit reached
> [ 102.245695] de2104x 0000:17:00.0 eth0: rx work limit reached
> [ 102.251387] de2104x 0000:17:00.0 eth0: rx work limit reached
> [ 102.267444] de2104x 0000:17:00.0 eth0: rx work limit reached
>
> Signed-off-by: Lucy Yan <lucyyan@google.com>
Reviewed-by: Moritz Fischer <mdf@kernel.org>
> ---
> drivers/net/ethernet/dec/tulip/de2104x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/dec/tulip/de2104x.c b/drivers/net/ethernet/dec/tulip/de2104x.c
> index cb116b530f5e..2610efe4f873 100644
> --- a/drivers/net/ethernet/dec/tulip/de2104x.c
> +++ b/drivers/net/ethernet/dec/tulip/de2104x.c
> @@ -85,7 +85,7 @@ MODULE_PARM_DESC (rx_copybreak, "de2104x Breakpoint at which Rx packets are copi
> #define DSL CONFIG_DE2104X_DSL
> #endif
>
> -#define DE_RX_RING_SIZE 64
> +#define DE_RX_RING_SIZE 128
> #define DE_TX_RING_SIZE 64
> #define DE_RING_BYTES \
> ((sizeof(struct de_desc) * DE_RX_RING_SIZE) + \
> --
> 2.28.0.526.ge36021eeef-goog
>
Thanks,
Moritz
next prev parent reply other threads:[~2020-09-10 19:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 19:05 [PATCH net] net: dec: de2104x: Increase receive ring size for Tulip Lucy Yan
2020-09-10 19:33 ` Moritz Fischer [this message]
2020-09-10 22:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200910193345.GA28525@archbook \
--to=mdf@kernel.org \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=lucyyan@google.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=vaibhavgupta40@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).