From: Vadym Kochan <vadym.kochan@plvision.eu>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Jiri Pirko <jiri@mellanox.com>,
Ido Schimmel <idosch@mellanox.com>, Andrew Lunn <andrew@lunn.ch>,
Oleksandr Mazur <oleksandr.mazur@plvision.eu>,
Serhiy Boiko <serhiy.boiko@plvision.eu>,
Serhiy Pshyk <serhiy.pshyk@plvision.eu>,
Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>,
Taras Chornyi <taras.chornyi@plvision.eu>,
Andrii Savka <andrii.savka@plvision.eu>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Mickey Rachamim <mickeyr@marvell.com>
Subject: Re: [net-next v8 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices
Date: Fri, 11 Sep 2020 10:02:12 +0300 [thread overview]
Message-ID: <20200911070212.GA17183@plvision.eu> (raw)
In-Reply-To: <20200910183047.39e4cd7c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Thu, Sep 10, 2020 at 06:30:47PM -0700, Jakub Kicinski wrote:
> On Thu, 10 Sep 2020 18:00:50 +0300 Vadym Kochan wrote:
> > +static int prestera_sdma_tx_wait(struct prestera_sdma *sdma,
> > + struct prestera_tx_ring *tx_ring)
> > +{
> > + int tx_wait_num = PRESTERA_SDMA_WAIT_MUL * tx_ring->max_burst;
> > + bool is_ready;
> > +
> > + return read_poll_timeout_atomic(prestera_sdma_is_ready, is_ready, true,
> > + 1, tx_wait_num, false, sdma);
> > +}
>
> This is strange and generates a warning:
>
> drivers/net/ethernet/marvell/prestera/prestera_rxtx.c: In function ‘prestera_sdma_tx_wait’:
> drivers/net/ethernet/marvell/prestera/prestera_rxtx.c:695:7: warning: variable ‘is_ready’ set but not used [-Wunused-but-set-variable]
> 695 | bool is_ready;
> | ^~~~~~~~
Sorry about this mistake, will re-submit new version.
next prev parent reply other threads:[~2020-09-11 7:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 15:00 [net-next v8 0/6] net: marvell: prestera: Add Switchdev driver for Prestera family ASIC device 98DX3255 (AC3x) Vadym Kochan
2020-09-10 15:00 ` [net-next v8 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices Vadym Kochan
2020-09-11 1:30 ` Jakub Kicinski
2020-09-11 7:02 ` Vadym Kochan [this message]
2020-09-10 15:00 ` [net-next v8 2/6] net: marvell: prestera: Add PCI interface support Vadym Kochan
2020-09-10 15:00 ` [net-next v8 3/6] net: marvell: prestera: Add basic devlink support Vadym Kochan
2020-09-10 15:00 ` [net-next v8 4/6] net: marvell: prestera: Add ethtool interface support Vadym Kochan
2020-09-10 15:00 ` [net-next v8 5/6] net: marvell: prestera: Add Switchdev driver implementation Vadym Kochan
2020-09-10 15:00 ` [net-next v8 6/6] dt-bindings: marvell,prestera: Add description for device-tree bindings Vadym Kochan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200911070212.GA17183@plvision.eu \
--to=vadym.kochan@plvision.eu \
--cc=andrew@lunn.ch \
--cc=andrii.savka@plvision.eu \
--cc=andy.shevchenko@gmail.com \
--cc=davem@davemloft.net \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mickeyr@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=oleksandr.mazur@plvision.eu \
--cc=serhiy.boiko@plvision.eu \
--cc=serhiy.pshyk@plvision.eu \
--cc=taras.chornyi@plvision.eu \
--cc=volodymyr.mytnyk@plvision.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).