From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8A8FC43461 for ; Fri, 11 Sep 2020 11:58:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A47DC221EB for ; Fri, 11 Sep 2020 11:58:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599825481; bh=OGz8xp4DfNbeDLLobWhgOPaKtHeGjBzxJ1PU9o8tCI8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=KcZaE2tRAAcyiPA5VZhxFcOz2r/HDhd7X99rak7ZzcT0+xgoXmcj1fo13kUcn5NFl s7Qd9fMTxq5XsDUeUwOnsvSCCOikXfWMz6er+gvlwT3R56gC5IMZOp1Safe7a/kWEE 7M9uVGRW4ZY3my4DoPWNPyfVNbVhrt8b7+DJMnKg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725815AbgIKL5w (ORCPT ); Fri, 11 Sep 2020 07:57:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:35032 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725730AbgIKL5s (ORCPT ); Fri, 11 Sep 2020 07:57:48 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C0EE6221E7; Fri, 11 Sep 2020 11:57:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599825466; bh=OGz8xp4DfNbeDLLobWhgOPaKtHeGjBzxJ1PU9o8tCI8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HmkktZevp+Gs6mdLYJRyYRMZq9zekb9HXwVQ+kbJ2ZqfxN5gL02wCFOKbZHCVLuf1 TdoaPTQtk4bYdFitgdzZTfz6RVOiJRoJtqokUWCNOTwRLGP69kDsyemX+KBPLX89wc Cl41jfFTQSeI0hKl/37dzwzPHmzDoKhW4F6Efe9I= Date: Fri, 11 Sep 2020 13:57:52 +0200 From: Greg Kroah-Hartman To: Saeed Mahameed Cc: Saeed Mahameed , linux-kernel@vger.kernel.org, stable@vger.kernel.org, netdev@vger.kernel.org, Roi Dayan Subject: Re: [PATCH 4.19] net/mlx5e: Don't support phys switch id if not in switchdev mode Message-ID: <20200911115752.GA3717176@kroah.com> References: <20200807020542.636290-1-saeedm@mellanox.com> <20200807131323.GA664450@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Sep 10, 2020 at 11:46:36AM -0700, Saeed Mahameed wrote: > On Fri, 2020-08-07 at 15:13 +0200, Greg Kroah-Hartman wrote: > > On Thu, Aug 06, 2020 at 07:05:42PM -0700, Saeed Mahameed wrote: > > > From: Roi Dayan > > > > > > Support for phys switch id ndo added for representors and if > > > we do not have representors there is no need to support it. > > > Since each port return different switch id supporting this > > > block support for creating bond over PFs and attaching to bridge > > > in legacy mode. > > > > > > This bug doesn't exist upstream as the code got refactored and the > > > netdev api is totally different. > > > > > > Fixes: cb67b832921c ("net/mlx5e: Introduce SRIOV VF representors") > > > Signed-off-by: Roi Dayan > > > Signed-off-by: Saeed Mahameed > > > --- > > > Hi Greg, > > > > > > Sorry for submitting a non upstream patch, but this bug is > > > bothering some users on 4.19-stable kernels and it doesn't exist > > > upstream, so i hope you are ok with backporting this one liner > > > patch. > > > > Also queued up to 4.9.y and 4.14.y. > > > > Hi Greg, the request was originally made for 4.19.y kernel, > I see the patch in 4.9 and 4.14 but not in 4.19 can we push it to 4.19 > as well ? Very odd, don't know what happened. Now fixed up, thanks. greg k-h