From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Edward Cree <ecree@solarflare.com>
Cc: <netdev@vger.kernel.org>, <intel-wired-lan@lists.osuosl.org>
Subject: Re: [RFC PATCH net-next v1 11/11] drivers/net/ethernet: clean up mis-targeted comments
Date: Fri, 11 Sep 2020 14:42:07 -0700 [thread overview]
Message-ID: <20200911144207.00005619@intel.com> (raw)
In-Reply-To: <227d2fe4-ddf8-89c9-b80b-142674c2cca0@solarflare.com>
Edward Cree wrote:
> On 11/09/2020 02:23, Jesse Brandeburg wrote:
> > + * @MC_CMD_PTP_IN_TRANSMIT_LENMAX: hack to get W=1 to compile
> I think I'd rather have a bogus warning than bogus kerneldocto suppress it;
> please drop this line (and encourage toolchain folks to figure out how to
> get kerneldoc to ignore macros it can't understand).
> Apart from that, the sfc and sfc/falcon parts LGTM.
>
> -ed
Thanks Ed, I think I might just remove the /** on that function then
(removing it from kdoc processing), would that be acceptable in the
meantime? Of course I'd remove the line I added as well.
- Jesse
next prev parent reply other threads:[~2020-09-11 21:42 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 1:23 [RFC PATCH net-next v1 00/11] make drivers/net/ethernet W=1 clean Jesse Brandeburg
2020-09-11 1:23 ` [RFC PATCH net-next v1 01/11] i40e: prepare flash string in a simpler way Jesse Brandeburg
2020-09-11 1:23 ` [RFC PATCH net-next v1 02/11] i40e: clean up W=1 warnings in i40e Jesse Brandeburg
2020-09-23 2:02 ` [Intel-wired-lan] " Brown, Aaron F
2020-09-11 1:23 ` [RFC PATCH net-next v1 03/11] iavf: clean up W=1 warnings in iavf Jesse Brandeburg
2020-09-11 1:23 ` [RFC PATCH net-next v1 04/11] ixgbe: clean up W=1 warnings in ixgbe Jesse Brandeburg
2020-09-11 1:23 ` [RFC PATCH net-next v1 05/11] intel-ethernet: make W=1 build cleanly Jesse Brandeburg
2020-09-11 17:43 ` [Intel-wired-lan] " Vinicius Costa Gomes
2020-09-11 23:28 ` Jesse Brandeburg
2020-09-11 1:23 ` [RFC PATCH net-next v1 06/11] drivers/net/ethernet: clean up unused assignments Jesse Brandeburg
2020-09-11 17:16 ` Edward Cree
2020-09-11 1:23 ` [RFC PATCH net-next v1 07/11] drivers/net/ethernet: rid ethernet of no-prototype warnings Jesse Brandeburg
2020-09-11 1:23 ` [RFC PATCH net-next v1 08/11] drivers/net/ethernet: handle one warning explicitly Jesse Brandeburg
2020-09-11 22:56 ` Jacob Keller
2020-09-11 1:23 ` [RFC PATCH net-next v1 09/11] drivers/net/ethernet: add some basic kdoc tags Jesse Brandeburg
2020-09-11 1:23 ` [RFC PATCH net-next v1 10/11] drivers/net/ethernet: remove incorrectly formatted doc Jesse Brandeburg
2020-09-11 1:23 ` [RFC PATCH net-next v1 11/11] drivers/net/ethernet: clean up mis-targeted comments Jesse Brandeburg
2020-09-11 17:26 ` Edward Cree
2020-09-11 21:42 ` Jesse Brandeburg [this message]
2020-09-11 21:55 ` Edward Cree
2020-09-11 22:26 ` Jakub Kicinski
2020-09-11 23:11 ` Edward Cree
2020-09-12 0:49 ` Jesse Brandeburg
2020-09-14 3:04 ` Andrew Lunn
2020-09-11 14:55 ` [RFC PATCH net-next v1 00/11] make drivers/net/ethernet W=1 clean Jakub Kicinski
2020-09-11 19:00 ` Jesse Brandeburg
2020-09-11 20:12 ` Jakub Kicinski
2020-09-11 21:34 ` Jesse Brandeburg
2020-09-11 22:16 ` Jakub Kicinski
2020-09-11 22:43 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200911144207.00005619@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=ecree@solarflare.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).