From: Vladimir Oltean <olteanv@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, mkubecek@suse.cz,
michael.chan@broadcom.com, tariqt@nvidia.com, saeedm@nvidia.com,
alexander.duyck@gmail.com, andrew@lunn.ch
Subject: Re: [PATCH net-next v2 0/8] ethtool: add pause frame stats
Date: Sat, 12 Sep 2020 02:49:32 +0300 [thread overview]
Message-ID: <20200911234932.ncrmapwpqjnphdv5@skbuf> (raw)
In-Reply-To: <20200911232853.1072362-1-kuba@kernel.org>
On Fri, Sep 11, 2020 at 04:28:45PM -0700, Jakub Kicinski wrote:
> Hi!
>
> This is the first (small) series which exposes some stats via
> the corresponding ethtool interface. Here (thanks to the
> excitability of netlink) we expose pause frame stats via
> the same interfaces as ethtool -a / -A.
>
> In particular the following stats from the standard:
> - 30.3.4.2 aPAUSEMACCtrlFramesTransmitted
> - 30.3.4.3 aPAUSEMACCtrlFramesReceived
>
> 4 real drivers are converted, hopefully the semantics match
> the standard.
>
> v2:
> - netdevsim: add missing static
> - bnxt: fix sparse warning
> - mlx5: address Saeed's comments
>
> Jakub Kicinski (8):
> ethtool: add standard pause stats
> docs: net: include the new ethtool pause stats in the stats doc
> netdevsim: add pause frame stats
> selftests: add a test for ethtool pause stats
> bnxt: add pause frame stats
> ixgbe: add pause frame stats
> mlx5: add pause frame stats
> mlx4: add pause frame stats
>
> Documentation/networking/ethtool-netlink.rst | 11 ++
> Documentation/networking/statistics.rst | 57 ++++++++-
> .../net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 17 +++
> .../net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 11 ++
> .../net/ethernet/mellanox/mlx4/en_ethtool.c | 19 +++
> .../net/ethernet/mellanox/mlx4/mlx4_stats.h | 12 ++
> .../ethernet/mellanox/mlx5/core/en_ethtool.c | 9 ++
> .../net/ethernet/mellanox/mlx5/core/en_rep.c | 9 ++
> .../ethernet/mellanox/mlx5/core/en_stats.c | 29 +++++
> .../ethernet/mellanox/mlx5/core/en_stats.h | 3 +
> drivers/net/netdevsim/Makefile | 2 +-
> drivers/net/netdevsim/ethtool.c | 64 +++++++++++
> drivers/net/netdevsim/netdev.c | 1 +
> drivers/net/netdevsim/netdevsim.h | 11 ++
> include/linux/ethtool.h | 26 +++++
> include/uapi/linux/ethtool_netlink.h | 18 ++-
> net/ethtool/pause.c | 57 ++++++++-
> .../drivers/net/netdevsim/ethtool-pause.sh | 108 ++++++++++++++++++
> 18 files changed, 456 insertions(+), 8 deletions(-)
> create mode 100644 drivers/net/netdevsim/ethtool.c
> create mode 100755 tools/testing/selftests/drivers/net/netdevsim/ethtool-pause.sh
>
> --
> 2.26.2
>
DSA used to override the "ethtool -S" callback of the host port, and
append its own CPU port counters to that.
So you could actually see pause frames transmitted by the host port and
received by the switch's CPU port:
# ethtool -S eno2 | grep pause
MAC rx valid pause frames: 1339603152
MAC tx valid pause frames: 0
p04_rx_pause: 0
p04_tx_pause: 1339603152
With this new command what's the plan?
Thanks,
-Vladimir
next prev parent reply other threads:[~2020-09-11 23:49 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 23:28 [PATCH net-next v2 0/8] ethtool: add pause frame stats Jakub Kicinski
2020-09-11 23:28 ` [PATCH net-next v2 1/8] ethtool: add standard pause stats Jakub Kicinski
2020-09-14 1:48 ` Andrew Lunn
2020-09-14 15:48 ` Jakub Kicinski
2020-09-14 17:18 ` Andrew Lunn
2020-09-14 18:58 ` Jakub Kicinski
2020-09-11 23:28 ` [PATCH net-next v2 2/8] docs: net: include the new ethtool pause stats in the stats doc Jakub Kicinski
2020-09-14 19:33 ` Saeed Mahameed
2020-09-14 19:52 ` Jakub Kicinski
2020-09-14 21:19 ` Saeed Mahameed
2020-09-11 23:28 ` [PATCH net-next v2 3/8] netdevsim: add pause frame stats Jakub Kicinski
2020-09-11 23:28 ` [PATCH net-next v2 4/8] selftests: add a test for ethtool pause stats Jakub Kicinski
2020-09-11 23:28 ` [PATCH net-next v2 5/8] bnxt: add pause frame stats Jakub Kicinski
2020-09-11 23:28 ` [PATCH net-next v2 6/8] ixgbe: " Jakub Kicinski
2020-09-11 23:28 ` [PATCH net-next v2 7/8] mlx5: " Jakub Kicinski
2020-09-12 1:10 ` Jakub Kicinski
2020-09-13 8:16 ` kernel test robot
2020-09-11 23:28 ` [PATCH net-next v2 8/8] mlx4: " Jakub Kicinski
2020-09-11 23:49 ` Vladimir Oltean [this message]
2020-09-12 0:07 ` [PATCH net-next v2 0/8] ethtool: " Jakub Kicinski
2020-09-12 0:15 ` Vladimir Oltean
2020-09-12 0:42 ` Jakub Kicinski
2020-09-12 2:54 ` Florian Fainelli
2020-09-14 15:53 ` Jakub Kicinski
2020-09-14 16:25 ` Florian Fainelli
2020-09-14 16:54 ` Jakub Kicinski
2020-09-14 17:36 ` Andrew Lunn
2020-09-14 19:20 ` Jakub Kicinski
2020-09-12 7:16 ` Vladimir Oltean
2020-09-14 16:15 ` Jakub Kicinski
2020-09-14 17:28 ` Andrew Lunn
2020-09-14 19:36 ` Jakub Kicinski
2020-09-14 2:08 ` Andrew Lunn
2020-09-14 16:26 ` Jakub Kicinski
2020-09-14 20:05 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200911234932.ncrmapwpqjnphdv5@skbuf \
--to=olteanv@gmail.com \
--cc=alexander.duyck@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).