From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF082C43461 for ; Sat, 12 Sep 2020 06:35:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 73326221E3 for ; Sat, 12 Sep 2020 06:35:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="eStWslLv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725848AbgILGfC (ORCPT ); Sat, 12 Sep 2020 02:35:02 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:44730 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725813AbgILGe6 (ORCPT ); Sat, 12 Sep 2020 02:34:58 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1599892497; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=TZbeRycGRlE5zMmEDJ3WaYnEdaM+rXIMHX3RcmeDB2w=; b=eStWslLvbM6tI+/rBxUeifkKt+8vUp8wMiboWKvPGjlpRA4ZMosNGvx6Ash4iHiJLJFgGw6d FvIURuULAbdGH21PqU32jmXNCBBw34jT4helVD+teh3p3vAfTWqXC12lZpP6iJ0ea6fA84mP PXDeG8fXn5vMEzFbXYEPhbLSRpk= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyJiZjI2MiIsICJuZXRkZXZAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-east-1.postgun.com with SMTP id 5f5c6c10238e1efa37b2c9c6 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sat, 12 Sep 2020 06:34:56 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id C3FA3C433CA; Sat, 12 Sep 2020 06:34:55 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id D0377C433CA; Sat, 12 Sep 2020 06:34:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D0377C433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH 06/29] wil6210: Fix a couple of formatting issues in 'wil6210_debugfs_init' From: Kalle Valo In-Reply-To: <20200910065431.657636-7-lee.jones@linaro.org> References: <20200910065431.657636-7-lee.jones@linaro.org> To: Lee Jones Cc: davem@davemloft.net, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , wil6210@qti.qualcomm.com, Maya Erez User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20200912063455.C3FA3C433CA@smtp.codeaurora.org> Date: Sat, 12 Sep 2020 06:34:55 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Lee Jones wrote: > Kerneldoc expects attributes/parameters to be in '@*.: ' format and > gets confused if the variable does not follow the type/attribute > definitions. > > Fixes the following W=1 kernel build warning(s): > > drivers/net/wireless/ath/wil6210/debugfs.c:456: warning: Function parameter or member 'wil' not described in 'wil6210_debugfs_init_offset' > drivers/net/wireless/ath/wil6210/debugfs.c:456: warning: Function parameter or member 'dbg' not described in 'wil6210_debugfs_init_offset' > drivers/net/wireless/ath/wil6210/debugfs.c:456: warning: Function parameter or member 'base' not described in 'wil6210_debugfs_init_offset' > drivers/net/wireless/ath/wil6210/debugfs.c:456: warning: Function parameter or member 'tbl' not described in 'wil6210_debugfs_init_offset' > > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: linux-wireless@vger.kernel.org > Cc: wil6210@qti.qualcomm.com > Cc: netdev@vger.kernel.org > Reviewed-by: Maya Erez > Signed-off-by: Lee Jones Aren't these also applied already? Please don't resend already applied patches. 8 patches set to Rejected. 11766845 [06/29] wil6210: Fix a couple of formatting issues in 'wil6210_debugfs_init' 11766747 [16/29] wil6210: wmi: Fix formatting and demote non-conforming function headers 11766827 [17/29] wil6210: interrupt: Demote comment header which is clearly not kernel-doc 11766825 [18/29] wil6210: txrx: Demote obvious abuse of kernel-doc 11766823 [19/29] wil6210: txrx_edma: Demote comments which are clearly not kernel-doc 11766821 [20/29] wil6210: pmc: Demote a few nonconformant kernel-doc function headers 11766819 [21/29] wil6210: wil_platform: Demote kernel-doc header to standard comment block 11766817 [22/29] wil6210: wmi: Correct misnamed function parameter 'ptr_' -- https://patchwork.kernel.org/patch/11766845/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches