From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Alex Elder <elder@linaro.org>
Cc: davem@davemloft.net, kuba@kernel.org, evgreen@chromium.org,
subashab@codeaurora.org, cpratapa@codeaurora.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 6/7] net: ipa: enable wakeup on IPA interrupt
Date: Sat, 12 Sep 2020 21:47:59 -0500 [thread overview]
Message-ID: <20200913024759.GP3715@yoga> (raw)
In-Reply-To: <20200912004532.1386-7-elder@linaro.org>
On Fri 11 Sep 19:45 CDT 2020, Alex Elder wrote:
> Now that we handle wakeup interrupts properly, arrange for the IPA
> interrupt to be treated as a wakeup interrupt.
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Alex Elder <elder@linaro.org>
> ---
> drivers/net/ipa/ipa_interrupt.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/net/ipa/ipa_interrupt.c b/drivers/net/ipa/ipa_interrupt.c
> index 90353987c45fc..cc1ea28f7bc2e 100644
> --- a/drivers/net/ipa/ipa_interrupt.c
> +++ b/drivers/net/ipa/ipa_interrupt.c
> @@ -237,8 +237,16 @@ struct ipa_interrupt *ipa_interrupt_setup(struct ipa *ipa)
> goto err_kfree;
> }
>
> + ret = enable_irq_wake(irq);
> + if (ret) {
> + dev_err(dev, "error %d enabling wakeup for \"ipa\" IRQ\n", ret);
> + goto err_free_irq;
> + }
> +
> return interrupt;
>
> +err_free_irq:
> + free_irq(interrupt->irq, interrupt);
> err_kfree:
> kfree(interrupt);
>
> @@ -248,6 +256,12 @@ struct ipa_interrupt *ipa_interrupt_setup(struct ipa *ipa)
> /* Tear down the IPA interrupt framework */
> void ipa_interrupt_teardown(struct ipa_interrupt *interrupt)
> {
> + struct device *dev = &interrupt->ipa->pdev->dev;
> + int ret;
> +
> + ret = disable_irq_wake(interrupt->irq);
> + if (ret)
> + dev_err(dev, "error %d disabling \"ipa\" IRQ wakeup\n", ret);
> free_irq(interrupt->irq, interrupt);
> kfree(interrupt);
> }
> --
> 2.20.1
>
next prev parent reply other threads:[~2020-09-13 2:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-12 0:45 [PATCH net-next v2 0/7] net: ipa: wake up system on RX available Alex Elder
2020-09-12 0:45 ` [PATCH net-next v2 1/7] net: ipa: use refcount_t for IPA clock reference count Alex Elder
2020-09-12 0:45 ` [PATCH net-next v2 2/7] net: ipa: replace ipa->suspend_ref with a flag bit Alex Elder
2020-09-12 0:45 ` [PATCH net-next v2 3/7] net: ipa: verify reference flag values Alex Elder
2020-09-13 2:25 ` Bjorn Andersson
2020-09-13 13:36 ` Alex Elder
2020-09-12 0:45 ` [PATCH net-next v2 4/7] net: ipa: manage endpoints separate from clock Alex Elder
2020-09-13 2:30 ` Bjorn Andersson
2020-09-12 0:45 ` [PATCH net-next v2 5/7] net: ipa: use device_init_wakeup() Alex Elder
2020-09-13 2:27 ` Bjorn Andersson
2020-09-12 0:45 ` [PATCH net-next v2 6/7] net: ipa: enable wakeup on IPA interrupt Alex Elder
2020-09-13 2:47 ` Bjorn Andersson [this message]
2020-09-12 0:45 ` [PATCH net-next v2 7/7] net: ipa: do not enable GSI interrupt for wakeup Alex Elder
2020-09-13 2:50 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200913024759.GP3715@yoga \
--to=bjorn.andersson@linaro.org \
--cc=cpratapa@codeaurora.org \
--cc=davem@davemloft.net \
--cc=elder@linaro.org \
--cc=evgreen@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=subashab@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).