From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B6FEC433E2 for ; Sun, 13 Sep 2020 02:48:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AF2F4207EA for ; Sun, 13 Sep 2020 02:48:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NmIFRPIW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725923AbgIMCsX (ORCPT ); Sat, 12 Sep 2020 22:48:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725907AbgIMCsG (ORCPT ); Sat, 12 Sep 2020 22:48:06 -0400 Received: from mail-ot1-x343.google.com (mail-ot1-x343.google.com [IPv6:2607:f8b0:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B393C061573 for ; Sat, 12 Sep 2020 19:48:06 -0700 (PDT) Received: by mail-ot1-x343.google.com with SMTP id e23so11777817otk.7 for ; Sat, 12 Sep 2020 19:48:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=gi4RgsDejluKNSDuptpFIorLHS9rpKmYHVtwd6skt4k=; b=NmIFRPIWmLgyTP+WVcCdvtq7yQAko5YmzN4qDAVmZKtvg+m5NLLO6fPRznrj3VO+57 Wk4eJ/T8q07qtNuurteTNnTG4t4Nm10rAL14ThV8lcpZpdYoGElQITH1Z2RiIgHHsCeN RalGVjnznh8VaE+1QXmIB+/xPy9vnlwMWVAQpALDQeltiuOXSlUdusfE3X3Vk7i7Z1RE 4vVR/1g20y2kOFNFCF2rCalY0auJ5qni5IBPbmPwn40zbI949FVBdJjsRWnusAcamHeE CEV+63+rEqgMhWSNwVoGvZ+b7POr8HPKsQDKh0Lw6JfiofkOj6CNyZLchrjTwxJlE0xO PWXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=gi4RgsDejluKNSDuptpFIorLHS9rpKmYHVtwd6skt4k=; b=HHGt8S17Fjg+jPB5GHoo6a4cY15xh/CLuTPUkh+pL0FYzeeFfVj4Dij8dH55hVg+Jl As3KWnwNVMdYZFhOYvQFKRxlsnjIIDVKmXpygt58oTUbMOtaBxG3OYQ+G1cy29/sFRkR 7dRGx3qtY2gkSvzH1lKAotJcD4qQHDWN64x53zKTYaCRhDHqci5A/nru8rVl7pkjNPwF l4thPlQc+nh+bU031zvZMfn+ODyqzSwqEaQq94WJicCiykaTQtM0wBEH0NCGODvzeIPb ItG7E8plM2UlnJaCNatBial1gchA0Etyjl4fpbDNIjG6SBD+DkKIY1PgzrEeEwyLe9Ks XjOw== X-Gm-Message-State: AOAM533oGUbFUck9YmAhdb6Wcb+eQHNZVSXCTAHtY3CjxROmQ9gE++44 JOhU6X9RG7j7Vdykl8+0aWoPjw== X-Google-Smtp-Source: ABdhPJzawApxC6RklfJj5492nsUZevZw9PqKX+Z+w9zrVwfyp8ba1Ma9z+eFpUfgvNxYIPnIq5w70w== X-Received: by 2002:a9d:4c06:: with SMTP id l6mr5401432otf.359.1599965285586; Sat, 12 Sep 2020 19:48:05 -0700 (PDT) Received: from yoga ([2605:6000:e5cb:c100:8898:14ff:fe6d:34e]) by smtp.gmail.com with ESMTPSA id k19sm1229228otb.45.2020.09.12.19.48.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Sep 2020 19:48:04 -0700 (PDT) Date: Sat, 12 Sep 2020 21:47:59 -0500 From: Bjorn Andersson To: Alex Elder Cc: davem@davemloft.net, kuba@kernel.org, evgreen@chromium.org, subashab@codeaurora.org, cpratapa@codeaurora.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2 6/7] net: ipa: enable wakeup on IPA interrupt Message-ID: <20200913024759.GP3715@yoga> References: <20200912004532.1386-1-elder@linaro.org> <20200912004532.1386-7-elder@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200912004532.1386-7-elder@linaro.org> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri 11 Sep 19:45 CDT 2020, Alex Elder wrote: > Now that we handle wakeup interrupts properly, arrange for the IPA > interrupt to be treated as a wakeup interrupt. > Reviewed-by: Bjorn Andersson > Signed-off-by: Alex Elder > --- > drivers/net/ipa/ipa_interrupt.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/net/ipa/ipa_interrupt.c b/drivers/net/ipa/ipa_interrupt.c > index 90353987c45fc..cc1ea28f7bc2e 100644 > --- a/drivers/net/ipa/ipa_interrupt.c > +++ b/drivers/net/ipa/ipa_interrupt.c > @@ -237,8 +237,16 @@ struct ipa_interrupt *ipa_interrupt_setup(struct ipa *ipa) > goto err_kfree; > } > > + ret = enable_irq_wake(irq); > + if (ret) { > + dev_err(dev, "error %d enabling wakeup for \"ipa\" IRQ\n", ret); > + goto err_free_irq; > + } > + > return interrupt; > > +err_free_irq: > + free_irq(interrupt->irq, interrupt); > err_kfree: > kfree(interrupt); > > @@ -248,6 +256,12 @@ struct ipa_interrupt *ipa_interrupt_setup(struct ipa *ipa) > /* Tear down the IPA interrupt framework */ > void ipa_interrupt_teardown(struct ipa_interrupt *interrupt) > { > + struct device *dev = &interrupt->ipa->pdev->dev; > + int ret; > + > + ret = disable_irq_wake(interrupt->irq); > + if (ret) > + dev_err(dev, "error %d disabling \"ipa\" IRQ wakeup\n", ret); > free_irq(interrupt->irq, interrupt); > kfree(interrupt); > } > -- > 2.20.1 >